Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1771136pxx; Fri, 30 Oct 2020 20:09:49 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxF/rOazdVe43k243OvNs51D+DC43nXjFpd0fBz/UFxTfJyLI5c1ik7PshAzzI8lUhEE3AZ X-Received: by 2002:a50:99c3:: with SMTP id n3mr5775764edb.213.1604113789425; Fri, 30 Oct 2020 20:09:49 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604113789; cv=none; d=google.com; s=arc-20160816; b=yRprVz9841K4f6CdRYvAoDwCDsz/ukjTThCHVqnlm3efz6+BYq8eEk1ghHp51d2TgG o0CJaf6j1NTuU8MzaCTP4pcEOJgUOKyvzzB+qjCNWtO7yiGHxhljB/FjeC+BdzlVCd+X MdIIRVBw6UD0IRnc2G62iSJprr8U6qeJe56TJ1i/J3kzPFjmzbxflvuC7DT/ikrU4ep9 CM9YYTHs3aRhmsLVrKJweOICzIigf8X2pNJJRYFScm7HHUNDjpUo8hfElb9ihIWtWQsx OKQVN7r5hGCOBagWtalJyDz4M0sjq2QRmoPtfC8Csiavqttb5NORxgjmurT6DosJK59p n4KA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:cc:to:from; bh=0RnByKwJyfO6dAUTVwTrFl+0AACZfJ+A0hLIFDprQhY=; b=FEJN807HPL673+MWmL8zwEdcFtQb+i5BtEQqpRwa4vFzzEIwaEzm+bmm/ZhbKvGAuw gETQ/XziOtLaR74oQhhF/lGGwHf1SsLtimw0H43WQNgoEp/OXf7zfhM5vQjbYKmUlBRc T18YNAxLSw+x1upvgpr8uy+G/KNSAsgYUiZmPtE1Nop787+C6Arrwq6CXhyRHK+PrOm1 eVyTUwERN6+oFeCU3BcBNxhsnCt5+DM3gQuwuQuqaPuxwMll2i1OQ3Wp16h+O56ZA4qT qxNUf0hMeceOgQfzapDYv/S8nAY4VtvNSYSQFQl9klESz4nCqteeIjas6FmhJnNAYGw/ VwQw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id w8si3197390ejv.203.2020.10.30.20.09.26; Fri, 30 Oct 2020 20:09:49 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726226AbgJaDF7 (ORCPT + 99 others); Fri, 30 Oct 2020 23:05:59 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:7119 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725536AbgJaDF6 (ORCPT ); Fri, 30 Oct 2020 23:05:58 -0400 Received: from DGGEMS410-HUB.china.huawei.com (unknown [172.30.72.59]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CNPFZ54NGzLqyG; Sat, 31 Oct 2020 11:05:54 +0800 (CST) Received: from localhost (10.174.176.180) by DGGEMS410-HUB.china.huawei.com (10.3.19.210) with Microsoft SMTP Server id 14.3.487.0; Sat, 31 Oct 2020 11:05:44 +0800 From: YueHaibing To: , , CC: , Subject: [PATCH] serial: mctrl_gpio: Fix passing zero to 'ERR_PTR' warning Date: Sat, 31 Oct 2020 11:05:30 +0800 Message-ID: <20201031030530.1304-1-yuehaibing@huawei.com> X-Mailer: git-send-email 2.10.2.windows.1 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.174.176.180] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org drivers/tty/serial/serial_mctrl_gpio.c:214 mctrl_gpio_init() warn: passing zero to 'ERR_PTR' gpiod_to_irq() never return 0, so remove the useless test and make code more clear. Signed-off-by: YueHaibing --- drivers/tty/serial/serial_mctrl_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c index fb4781292d40..c41d8911ce95 100644 --- a/drivers/tty/serial/serial_mctrl_gpio.c +++ b/drivers/tty/serial/serial_mctrl_gpio.c @@ -207,7 +207,7 @@ struct mctrl_gpios *mctrl_gpio_init(struct uart_port *port, unsigned int idx) continue; ret = gpiod_to_irq(gpios->gpio[i]); - if (ret <= 0) { + if (ret < 0) { dev_err(port->dev, "failed to find corresponding irq for %s (idx=%d, err=%d)\n", mctrl_gpios_desc[i].name, idx, ret); -- 2.17.1