Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] pwm: tiehrpwm: handle deferred probe with dev_err_probe()
To:     Grygorii Strashko <grygorii.strashko@ti.com>,
        Thierry Reding <thierry.reding@gmail.com>,
        =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= <u.kleine-koenig@pengutronix.de>,
        Lee Jones <lee.jones@linaro.org>, <linux-pwm@vger.kernel.org>
CC:     <linux-kernel@vger.kernel.org>
References: <20201030201254.24557-1-grygorii.strashko@ti.com>
From:   Vignesh Raghavendra <vigneshr@ti.com>
Message-ID: <16e36940-1cae-a7f3-a024-7a772d0ad5f5@ti.com>
Date:   Sat, 31 Oct 2020 14:39:19 +0530
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <20201030201254.24557-1-grygorii.strashko@ti.com>
Content-Type: text/plain; charset="utf-8"
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 10/31/20 1:42 AM, Grygorii Strashko wrote:
> The devm_clk_get() may return -EPROBE_DEFER which is not handled properly
> by TI EHRPWM driver and causes unnecessary boot log messages.
> 
> Hence, add proper deferred probe handling with new dev_err_probe() API.
> 
> Signed-off-by: Grygorii Strashko <grygorii.strashko@ti.com>
> ---

Reviewed-by: Vignesh Raghavendra <vigneshr@ti.com>

>  drivers/pwm/pwm-tiehrpwm.c | 12 ++++--------
>  1 file changed, 4 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/pwm/pwm-tiehrpwm.c b/drivers/pwm/pwm-tiehrpwm.c
> index 0846917ff2d2..14c8fdcfd607 100644
> --- a/drivers/pwm/pwm-tiehrpwm.c
> +++ b/drivers/pwm/pwm-tiehrpwm.c
> @@ -437,10 +437,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> -	if (IS_ERR(clk)) {
> -		dev_err(&pdev->dev, "failed to get clock\n");
> -		return PTR_ERR(clk);
> -	}
> +	if (IS_ERR(clk))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(clk), "Failed to get fck\n");
>  
>  	pc->clk_rate = clk_get_rate(clk);
>  	if (!pc->clk_rate) {
> @@ -462,10 +460,8 @@ static int ehrpwm_pwm_probe(struct platform_device *pdev)
>  
>  	/* Acquire tbclk for Time Base EHRPWM submodule */
>  	pc->tbclk = devm_clk_get(&pdev->dev, "tbclk");
> -	if (IS_ERR(pc->tbclk)) {
> -		dev_err(&pdev->dev, "Failed to get tbclk\n");
> -		return PTR_ERR(pc->tbclk);
> -	}
> +	if (IS_ERR(pc->tbclk))
> +		return dev_err_probe(&pdev->dev, PTR_ERR(pc->tbclk), "Failed to get tbclk\n");
>  
>  	ret = clk_prepare(pc->tbclk);
>  	if (ret < 0) {
>