Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp1912357pxx; Sat, 31 Oct 2020 02:20:46 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxnQ2J4Uq8OY6G56tk8yjstQskRAGsfI+h3LLksDsceyprikLD9KkLSglw+3Jl6JcqLCS1X X-Received: by 2002:a05:6402:4d:: with SMTP id f13mr6784119edu.306.1604136046010; Sat, 31 Oct 2020 02:20:46 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1604136046; cv=none; d=google.com; s=arc-20160816; b=OLTPGVL4+Ek2njq0gAIXwiGemomkBemwYL1vP24nswPkm6C8/r3bf01c8I6WholAbi csHVhaa9BHRYA9yz/KFnhL6BrssRbO73ZRASyE2AOC3+63t5vNI5gNYkIU2usEhVWyUJ atsbZDFMWHWP7M0lk1RhktfKjvGOMtVj+swRxCRqnc5CzOhpfWkBkaRgdGq5EXthqr8m QOrFxsphBjEjE6XM2/XrN0hGAwa0ammmGd6K7ycEHoRB/LJFfjgJ+4YJlZaNEtY+R0iz 7dxSGzoUobbcWkxsiBZl+wGHgPR3/rF/ZmOPe8nVrR6zro6qEtXSLccxxx0UJfAPHr7w 7ZDQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=O98vctGJlMm54y7ZgkFRa5GNToqKQf+9E+2CGnC5b6k=; b=K+NxBlajAY4nVLwP/mwZaNeo5ECh2tH2H+gMx4lED4hmwbWxJg3K6nkz2l4keuA9S5 Xlqfqiwb7gUaLGzusVNdg6jnu1lqMsUEsj6oFXgMRLWGYVFM/pv5hHaYkgrNDxsyc6GW ZOcOokoQONj5rXyl2CVOc9IDTXn3QFkJrT2tZmyqrUKUzal2LI0iVWaqelPpzlhzHFif F32tgSklv0tY8zz5EUAyD40htCJq3rFJa6+FU2pHCWaIjeYsSkWxZMF0CBqvM3tDWE6T XsE5VGcU8gB+RxjnkpfyFZNulzM3tikEzFWZPHl0Ur6RLKPx854qD+rtfeC/SN8QuiXO H99Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Y3/3bCaJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f2si6195293ejc.542.2020.10.31.02.20.23; Sat, 31 Oct 2020 02:20:45 -0700 (PDT) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="Y3/3bCaJ"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726627AbgJaJSr (ORCPT + 99 others); Sat, 31 Oct 2020 05:18:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39502 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726623AbgJaJSm (ORCPT ); Sat, 31 Oct 2020 05:18:42 -0400 Received: from mail-yb1-xb44.google.com (mail-yb1-xb44.google.com [IPv6:2607:f8b0:4864:20::b44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 05C6DC0613D5 for ; Sat, 31 Oct 2020 02:18:41 -0700 (PDT) Received: by mail-yb1-xb44.google.com with SMTP id z7so5376925ybg.10 for ; Sat, 31 Oct 2020 02:18:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=O98vctGJlMm54y7ZgkFRa5GNToqKQf+9E+2CGnC5b6k=; b=Y3/3bCaJNeg5r7RyY83l0gNBsB6eZfAKpe8LX6g8nWg7avzzZEw3rC3bCEDDsP4nsu Gyz9RkXt+fHZ5RLSbq9Sq6z8yvatN7ZKS6qWQ1Yv69t55553k7ljcErkmMI584sUr3U4 uLqYt1lLVJJWVlz/0SG3wLJ1JWHCYF1P80GhsUpsh7Qfpb8823zp2UyTQHydRw/jt3xi TZHdhmaLoqS6bbTavQut44QMREnzbKml8keWciUDWdbXmHyHNy6dbGchfHLavbHedLGV OpViPqTmfJ3uL4tQ+tpY/S8He2Wbo4dIkifAZcdOJF/tofL6ijcIVbL06W4+yqRptuxz le/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=O98vctGJlMm54y7ZgkFRa5GNToqKQf+9E+2CGnC5b6k=; b=SrmK73qnUCb+QtYTXGkN6hKxN7cTt9/Dg9r0908PU/Y1+xdG62NT8euquyRzh4Nnhq kBoXV3CgBhvuHNfAmQodk6YkRXDLVXsvwHArhAgsKhdYVoIjRzfU1jS4bHYHn0dkgfbB /PslhoofSIbE9j/ibfl9Y5D0OXkxU1atvRUWCE7JsDpWzOWp7tKAuOIk+oAF5teus9sG 30tYlEW86RtSoiJxKnmjfbx5wwWeW4iz9TmqP05Nr7xAeO8BD1DlMIiHleL6nG5iUb5J lNvLC6M/eaXBJC/ODyyNfWi/5agwFG9vcJTKIeeqpiF+g+ViDhICRBvdlxdU2wMGr4VL ocHg== X-Gm-Message-State: AOAM531qKjOvflY4uie/g9rp0qTDwI5o2IcKEykQy/hJYoeUpOWwsuQO zKSOriLe3j+ghyWmtSTmejUybCi0sXwc/RJGFy23saKt6Zw= X-Received: by 2002:a25:384c:: with SMTP id f73mr8429950yba.135.1604135920359; Sat, 31 Oct 2020 02:18:40 -0700 (PDT) MIME-Version: 1.0 References: <20201029095231.311083-1-poeschel@lemonage.de> <20201029095731.311528-1-poeschel@lemonage.de> <20201029095731.311528-22-poeschel@lemonage.de> In-Reply-To: <20201029095731.311528-22-poeschel@lemonage.de> From: Miguel Ojeda Date: Sat, 31 Oct 2020 10:18:29 +0100 Message-ID: Subject: Re: [PATCH v5 23/25] auxdisplay: charlcd: Do not print chars at end of line To: Lars Poeschel Cc: open list , Willy Tarreau Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Lars, A few extra typos in this commit message. On Thu, Oct 29, 2020 at 10:58 AM wrote: > > Skip printing characters at the end of a display line. This fits to the > behaviour we already had, that the cursor is nailed to last position of to last -> to the last > a line. > This might slightly change behaviour. > On hd44780 displays with one or two lines the previous implementation > did still write characters to the buffer of the display even if they are > currently not visible. The shift_display command could be used so set so -> to > the "viewing window" to a new position in the buffer and then you could > see the characters previously written. > This described behaviour does not work for hd44780 displays with more > than two display lines. There simply is not enough buffer. > So the behaviour was a bit inconsistens across different displays. inconsistent -> inconsistent > The new behaviour is to stop writing character at the end of a visible character -> characters > line, even if there would be room in the buffer. This allows us to have > an easy implementation, that should behave equal on all supported > displays. This is not hd44780 hardware dependents anymore. dependents -> dependent Cheers, Miguel