Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201029095231.311083-1-poeschel@lemonage.de> <20201029095731.311528-1-poeschel@lemonage.de>
 <20201029095731.311528-22-poeschel@lemonage.de>
In-Reply-To: <20201029095731.311528-22-poeschel@lemonage.de>
From:   Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>
Date:   Sat, 31 Oct 2020 10:18:29 +0100
Message-ID: <CANiq72=R0FBG6Zx-_u8ZjYFLovUnAmnZS6HO4Qa0OYUyncPeVw@mail.gmail.com>
Subject: Re: [PATCH v5 23/25] auxdisplay: charlcd: Do not print chars at end
 of line
To:     Lars Poeschel <poeschel@lemonage.de>
Cc:     open list <linux-kernel@vger.kernel.org>, Willy Tarreau <w@1wt.eu>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

Hi Lars,

A few extra typos in this commit message.

On Thu, Oct 29, 2020 at 10:58 AM <poeschel@lemonage.de> wrote:
>
> Skip printing characters at the end of a display line. This fits to the
> behaviour we already had, that the cursor is nailed to last position of

to last -> to the last

> a line.
> This might slightly change behaviour.
> On hd44780 displays with one or two lines the previous implementation
> did still write characters to the buffer of the display even if they are
> currently not visible. The shift_display command could be used so set

so -> to

> the "viewing window" to a new position in the buffer and then you could
> see the characters previously written.
> This described behaviour does not work for hd44780 displays with more
> than two display lines. There simply is not enough buffer.
> So the behaviour was a bit inconsistens across different displays.

inconsistent -> inconsistent

> The new behaviour is to stop writing character at the end of a visible

character -> characters

> line, even if there would be room in the buffer. This allows us to have
> an easy implementation, that should behave equal on all supported
> displays. This is not hd44780 hardware dependents anymore.

dependents -> dependent

Cheers,
Miguel