Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp2216400pxx;
        Sat, 31 Oct 2020 12:00:56 -0700 (PDT)
X-Google-Smtp-Source: ABdhPJydD2GMQAbxlaaL4xUDd6vK/3YSUNsfPLGQrK04dasWaTiimmjkHKlLgf9nr9+jHDI1jxtG
X-Received: by 2002:aa7:c1d3:: with SMTP id d19mr9247653edp.293.1604170856734;
        Sat, 31 Oct 2020 12:00:56 -0700 (PDT)
ARC-Seal: i=1; a=rsa-sha256; t=1604170856; cv=none;
        d=google.com; s=arc-20160816;
        b=UNhk0h+mPO9YjB2TESVxRPgtjtq1VZli1TQ0jmSK2PDVoAunrYdiRa5BLPXfGBUhDS
         ZNLSJzLKWyBQedxqRbKgTPYJTsvkKDTQtBlsBQ4qaJQqW0uZRy3EwZCQTO4D93Fz3qu/
         DoHFjzgq1I0Bs9QjxMbtN353zpVKpLdLZha7xpry9dKwKuDVsWvl+C45gahVNacgta5F
         bAChrE5X/2q0Wa981AEGvthy6BmT7SaYv3ln1coVkNtW9eCLWIiFeEXVnlqdBdnbJOm9
         YuPa2FBH1fnQmTZtf5eWn50LaxpNU37lXUKw/OerBPaC7BV4aCZxuFMHgnD8CdyxvsTx
         iJgg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:in-reply-to:content-disposition:mime-version
         :references:message-id:subject:cc:to:from:date;
        bh=aOjL1UUUAMVuyInBvtxgNr6ij9BDCPkxZdpUntPcV/Y=;
        b=SgqtlaBwXInvc6lvL5+DbNl26wFDPrd+hmhSCnmXFxl6XwMKhuhD/u92VPijgEo49u
         V2uNNXBHS/AV4W3S29ZM0h60M9FQslhACJ5NKFckIo8HSP425RmYTw5zI76y9HJ20El0
         woW7dyIv7LlCgGrkA7nEwPg0bOui+GvM9X5q5JhLW+bTwfFerhf6R6vL3ElOIfyRk4ob
         RohfMShSwHV1xx3941oySfEYdumpLSbSLGAI/8RxOB+sQtfzcMR+GdhndlTdQMW7OJiL
         PS0hHsBvyjXn6NeEAIwuBMxRAn5grVx8BghyOcZkmL72uKcYhGuJuO5B5yUfP6cZlX1M
         P2Iw==
ARC-Authentication-Results: i=1; mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id a6si7951662edq.273.2020.10.31.12.00.19;
        Sat, 31 Oct 2020 12:00:56 -0700 (PDT)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728475AbgJaS4U (ORCPT <rfc822;zcyberian@gmail.com> + 99 others);
        Sat, 31 Oct 2020 14:56:20 -0400
Received: from vps0.lunn.ch ([185.16.172.187]:56642 "EHLO vps0.lunn.ch"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726627AbgJaS4U (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Sat, 31 Oct 2020 14:56:20 -0400
Received: from andrew by vps0.lunn.ch with local (Exim 4.94)
        (envelope-from <andrew@lunn.ch>)
        id 1kYw2n-004XiQ-Re; Sat, 31 Oct 2020 19:56:05 +0100
Date:   Sat, 31 Oct 2020 19:56:05 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     YueHaibing <yuehaibing@huawei.com>
Cc:     linux@armlinux.org.uk, hkallweit1@gmail.com, davem@davemloft.net,
        kuba@kernel.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sfp: Fix error handing in sfp_probe()
Message-ID: <20201031185605.GA932026@lunn.ch>
References: <20201031031053.25264-1-yuehaibing@huawei.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20201031031053.25264-1-yuehaibing@huawei.com>
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, Oct 31, 2020 at 11:10:53AM +0800, YueHaibing wrote:
> gpiod_to_irq() never return 0, but returns negative in
> case of error, check it and set gpio_irq to 0.
> 
> Fixes: 73970055450e ("sfp: add SFP module support")
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew