Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Sun, 1 Nov 2020 15:54:50 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     peng.fan@nxp.com
Cc:     sboyd@kernel.org, s.hauer@pengutronix.de, festevam@gmail.com,
        abel.vesa@nxp.com, kernel@pengutronix.de, linux-imx@nxp.com,
        Anson.Huang@nxp.com, linux-clk@vger.kernel.org,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        aisheng.dong@nxp.com
Subject: Re: [PATCH V2 0/5] clk: imx: fix bus critical clk registration
Message-ID: <20201101075449.GG31601@dragon>
References: <1603285820-30196-1-git-send-email-peng.fan@nxp.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1603285820-30196-1-git-send-email-peng.fan@nxp.com>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Wed, Oct 21, 2020 at 09:10:15PM +0800, peng.fan@nxp.com wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> V2:
>   Add missed Reported-by tag
>   Add R-b tag

I do not see either tag on any of the patches.

> 
> The issue is exposed by
> https://git.kernel.org/pub/scm/linux/kernel/git/shawnguo/
> linux.git/commit/?h=for-next&id=936c383673b9e3007432f17140ac62de53d87db9
> 
> Since the upper patch not in Linus tree, I not add Fixed tag.

It should be landed now.

Shawn

> 
> The issue is bus clk should be registered using bus composite api, not
> peripheral api. Otherwise we will met failed to assigned clock parents error log.
> Because peripheral critical clk has CLK_SET_PARENT_GATE and CLK_IS_CRITICAL,
> you will not able to set clk parents.
> 
> We need use bus critical clk api to register the clks, so introduce
> a new helper and use it.
> 
> Peng Fan (5):
>   clk: imx: add imx8m_clk_hw_composite_bus_critical
>   clk: imx8mq: fix noc and noc_io registration
>   clk: imx8mm: fix bus critical clk registration
>   clk: imx8mn: fix bus critical clk registration
>   clk: imx8mp: fix bus critical clk registration
> 
>  drivers/clk/imx/clk-imx8mm.c | 10 +++++-----
>  drivers/clk/imx/clk-imx8mn.c |  6 +++---
>  drivers/clk/imx/clk-imx8mp.c | 10 +++++-----
>  drivers/clk/imx/clk-imx8mq.c |  8 ++++----
>  drivers/clk/imx/clk.h        |  5 +++++
>  5 files changed, 22 insertions(+), 17 deletions(-)
> 
> -- 
> 2.28.0
>