Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Marc Zyngier <maz@kernel.org>
To:     Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        Geert Uytterhoeven <geert+renesas@glider.be>,
        Greentime Hu <greentime.hu@sifive.com>, palmer@dabbelt.com,
        linux-kernel@vger.kernel.org, atish.patra@wdc.com,
        linux-riscv@lists.infradead.org, paul.walmsley@sifive.com,
        anup@brainfault.org
Cc:     Ulrich Hecht <uli+renesas@fpond.eu>,
        linux-renesas-soc@vger.kernel.org
Subject: Re: [RFC PATCH] irqchip/sifive-plic: Fix getting wrong chip_data when interrupt is hierarchy
Date:   Sun,  1 Nov 2020 12:10:27 +0000
Message-Id: <160423261831.76459.6853837344029171039.b4-ty@kernel.org>
In-Reply-To: <20201029023738.127472-1-greentime.hu@sifive.com>
References: <20201029023738.127472-1-greentime.hu@sifive.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Precedence: bulk

On Thu, 29 Oct 2020 10:37:38 +0800, Greentime Hu wrote:
> This oops is caused by a wrong chip_data and it is because plic_irq_unmask
> uses irq_get_chip_data(irq_data->irq) to get the chip_data. However it may
> get another irq_data with the same irq_data->irq if it is hierarchy.
> 
> In this case, it will get irq_data of sifive_gpio_irqchip instead of
> plic_chip so that it will get a wrong chip_data and then the wrong lmask
> of it to cause this oops.
> 
> [...]

Applied to irq/irqchip-next, thanks!

[1/1] irqchip/sifive-plic: Fix chip_data access within a hierarchy
      commit: f9ac7bbd6e4540dcc6df621b9c9b6eb2e26ded1d

Cheers,

	M.
-- 
Without deviation from the norm, progress is not possible.