Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932193AbWHQHaY (ORCPT ); Thu, 17 Aug 2006 03:30:24 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932190AbWHQHaY (ORCPT ); Thu, 17 Aug 2006 03:30:24 -0400 Received: from smtp3.orange.fr ([193.252.22.28]:64533 "EHLO smtp-msa-out03.orange.fr") by vger.kernel.org with ESMTP id S932187AbWHQHaW (ORCPT ); Thu, 17 Aug 2006 03:30:22 -0400 X-ME-UUID: 20060817073020475.741F31C00112@mwinf0312.orange.fr Subject: Re: bonding: cannot remove certain named devices From: Xavier Bestel To: Bodo Eggert <7eggert@gmx.de> Cc: Bill Nottingham , "Giacomo A. Catenazzi" , David Miller , 7eggert@elstempel.de, shemminger@osdl.org, mitch.a.williams@intel.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org In-Reply-To: References: <6KfTz-OX-11@gated-at.bofh.it> <6KfTA-OX-15@gated-at.bofh.it> <20060815.171002.104028951.davem@davemloft.net> <44E2BC9C.1000101@debian.org> <20060816133811.GA26471@nostromo.devel.redhat.com> Content-Type: text/plain Message-Id: <1155799783.7566.5.camel@capoeira> Mime-Version: 1.0 X-Mailer: Ximian Evolution 1.4.5 (1.4.5-1) Date: Thu, 17 Aug 2006 09:29:43 +0200 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1354 Lines: 33 On Wed, 2006-08-16 at 17:11, Bodo Eggert wrote: > On Wed, 16 Aug 2006, Bill Nottingham wrote: > > Giacomo A. Catenazzi (cate@debian.org) said: > > > > > Are you willing to work to add the special case code necessary to > > > > handle whitespace characters in the device name over all of the kernel > > > > code and also all of the userland tools too? > > > > > > But if you don't handle spaces in userspace, you handle *, ?, [, ], $, > > > ", ', \ in userspace? Should kernel disable also these (insane device > > > chars) chars? > > > > Don't forget unicode characters! > > And long names or control characters. > > > Seriously, while it might be insane to use some of these, I'm wondering > > if trying to filter names is more work than fixing the tools. > > I think it's sane to avoid control characters and unicode/iso*, since they > can interfere with log output or analysis. I only thought about the kernel > itself and the corresponding userspace tools, which should handle any > character sequence just fine or could be easily fixed. Why not simply retricting chars to isalnum() ones ? Xav - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/