Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] xfrm/compat: Remove use of kmalloc_track_caller
To:     Alistair Delva <adelva@google.com>
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        Jakub Kicinski <kuba@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Herbert Xu <herbert@gondor.apana.org.au>,
        kernel-team@android.com,
        =?UTF-8?Q?Maciej_=c5=bbenczykowski?= <maze@google.com>,
        Steffen Klassert <steffen.klassert@secunet.com>
References: <20201101220845.2391858-1-adelva@google.com>
From:   Dmitry Safonov <0x7f454c46@gmail.com>
Message-ID: <1a85a545-a663-828a-387e-fd4a0e2ae747@gmail.com>
Date:   Sun, 1 Nov 2020 23:34:11 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <20201101220845.2391858-1-adelva@google.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 11/1/20 10:08 PM, Alistair Delva wrote:
> The __kmalloc_track_caller symbol is not exported if SLUB/SLOB are
> enabled instead of SLAB, which breaks the build on such configs when
> CONFIG_XFRM_USER_COMPAT=m.
> 
> ERROR: "__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined!
> 
> Other users of this symbol are 'bool' options, but changing this to
> bool would require XFRM_USER to be built in as well, which doesn't
> seem worth it. Go back to kmalloc().
> 
> Fixes: 96392ee5a13b9 ("xfrm/compat: Translate 32-bit user_policy from sockptr")
> Cc: Dmitry Safonov <0x7f454c46@gmail.com>
> Cc: Maciej Żenczykowski <maze@google.com>
> Cc: Steffen Klassert <steffen.klassert@secunet.com>
> Signed-off-by: Alistair Delva <adelva@google.com>

Reviewed-by: Dmitry Safonov <0x7f454c46@gmail.com>

Thank you!

--
          Dmitry