Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp2929904pxx; Sun, 1 Nov 2020 15:54:33 -0800 (PST) X-Google-Smtp-Source: ABdhPJzl8DVYBXZod2AjOx0Ln2tK+s2npktXcctPPf4L9T9+veP+rdJgnvROKyfPCkgitD279Bhe X-Received: by 2002:a17:906:b1d6:: with SMTP id bv22mr12646844ejb.60.1604274872876; Sun, 01 Nov 2020 15:54:32 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604274872; cv=none; d=google.com; s=arc-20160816; b=rDqOkOy+ALOWnKBKkhHQE/Y3AxeQuVx9UWNev1S7Dhq8IEzrj0m5zTllB7hUJGL2US RWXX0LkJyCkOw7x3PZeMT2+XDg1iqfRgH+1C+ZROrV3PgX0/DUiG1dbdHpw3dMzqL6U7 /OVcgOtu08Bhw08XaIsJJfXqtVnIUf1INfc0HxOxRcvCp/ObPkFOxEY2xAFJmiDvnQDg +KDD1eMwZLQkuPXxPRISHiOW7S2M4GexUJmoMfLtzSs4PCnRFNg6POp/GxU2wGSeDYpB OcJ7dQVAiI9tNzCCQU3EcDo3wduQSdQCFdV6DqNijMdw6Q4je8NFrQcUuUQ7MfkMBHId vS/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-transfer-encoding :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=4FNHDmw3Lh/Tb9ZRW/CKYpq7tIwRAtI0EOsMhCXJFQ8=; b=iXiWNhQGXVQ6W69DhP8ARErMCro8eMaNG7Okcr9nUxccy57bcmmOP9nodjUZAMmDql ctwY07AMQ47302IlinrYvbNGCK6nHgYPxLL81fWm3Ihj8em9Say06mKLXiDvdUwoFuzc 1rOj0OmqxXANb8jUaUYhjjglut5OZ36balAcwke56u09zrvFp5etEo1JEy11tSrmPgE1 GAtb4oHN3PF1hCTc2G7zBRiz1nmG4XAWhYSDSHnUM/tVtHCHSFG4ZkDIoDZFeJAHYUkg mMQk/RFSdSRmcdtuRqS/rMsMbc4bO3kk5z6wohPXZDq6uDfaBAOlF5SgKO0sZhQ4KIE0 PNpw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cjW0Lg12; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id bu20si4433218edb.222.2020.11.01.15.54.10; Sun, 01 Nov 2020 15:54:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cjW0Lg12; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727520AbgKAXwh (ORCPT + 99 others); Sun, 1 Nov 2020 18:52:37 -0500 Received: from mail.kernel.org ([198.145.29.99]:47166 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727062AbgKAXwh (ORCPT ); Sun, 1 Nov 2020 18:52:37 -0500 Received: from localhost (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF2882076E; Sun, 1 Nov 2020 23:52:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604274757; bh=yQZClf+XZ9bBDhmoyVluAnr1PP6WVc2KC3dk/ifcgQk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cjW0Lg12y2ExFO7hYR/2QYwZNM/JKunh+YhCPdFcfU1dLlEEoT+DRDyNOCRE21bBz 6cUWcGVFY8eb4Z0nPQGHrVh0EaEh4KNrnGnkx95M33uiaT0BmzJHF3c+4++yQJ/Wfb SaWpu5N1wr5awLEczgL2wBk1IMdLRd8oN6qTj7FA= Date: Sun, 1 Nov 2020 18:52:35 -0500 From: Sasha Levin To: Edward Cree Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Jakub Kicinski , netdev@vger.kernel.org Subject: Re: [PATCH AUTOSEL 5.9 054/147] sfc: add and use efx_tx_send_pending in tx.c Message-ID: <20201101235235.GB2092@sasha-vm> References: <20201026234905.1022767-1-sashal@kernel.org> <20201026234905.1022767-54-sashal@kernel.org> <0507e2d9-6535-277c-bd9a-a009c11bf795@solarflare.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1; format=flowed Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <0507e2d9-6535-277c-bd9a-a009c11bf795@solarflare.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Oct 27, 2020 at 01:24:24PM +0000, Edward Cree wrote: >On 26/10/2020 23:47, Sasha Levin wrote: >> From: Edward Cree >> >> [ Upstream commit 1c0544d24927e4fad04f858216b8ea767a3bd123 ] >> >> Instead of using efx_tx_queue_partner(), which relies on the assumption >> that tx_queues_per_channel is 2, efx_tx_send_pending() iterates over >> txqs with efx_for_each_channel_tx_queue(). >That assumption was valid for the code as of v5.9; this change was only >?needed to support the extra queues that were added for encap offloads. >Thus, this patch shouldn't be backported, unless -stable is also planning >?to backport that feature (e.g. 0ce8df661456, 24b2c3751aa3), which I >?doubt (it's nearly 20 patches, and can't be considered a bugfix). Right, now dropped - thanks! -- Thanks, Sasha