Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v3 00/14] iommu/amd: Add Generic IO Page Table Framework
 Support
To:     linux-kernel@vger.kernel.org, iommu@lists.linux-foundation.org
Cc:     joro@8bytes.org, robin.murphy@arm.com
References: <20201004014549.16065-1-suravee.suthikulpanit@amd.com>
From:   Suravee Suthikulpanit <suravee.suthikulpanit@amd.com>
Message-ID: <f28359ed-47dc-281f-7261-6320150ef906@amd.com>
Date:   Mon, 2 Nov 2020 10:16:20 +0700
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0)
 Gecko/20100101 Thunderbird/78.4.0
In-Reply-To: <20201004014549.16065-1-suravee.suthikulpanit@amd.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
Received: from Suravees-MacBook-Pro.local (183.89.247.160) by SGBP274CA0008.SGPP274.PROD.OUTLOOK.COM (2603:1096:4:b0::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.3499.18 via Frontend Transport; Mon, 2 Nov 2020 03:16:27 +0000
X-MS-PublicTrafficType: Email
X-MS-Office365-Filtering-HT: Tenant
X-MS-Office365-Filtering-Correlation-Id: ef0c667f-1d99-4c0d-9905-08d87eddb0a6
X-MS-TrafficTypeDiagnostic: BY5PR12MB4161:
X-Microsoft-Antispam-PRVS: <BY5PR12MB4161704C27EFC58DB383EB63F3100@BY5PR12MB4161.namprd12.prod.outlook.com>
X-MS-Oob-TLC-OOBClassifiers: OLM:7219;
X-MS-Exchange-SenderADCheck: 1
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 5Iqgg023CFrhcKTw4BcYIXZR47bJUG5E4F/5YQ0qxF/hr6d6/Xfc6HHzBrcHyimVCY9LXKaN43V9v4Kgl4m+CRZR/sUdhAfAEynwg9pJ9/3Xlx0JcoistaqbEj8a03qhQnrfu6NTGoZ8PJscA9vIsNHFcpBpFKYs6AT8l9/7haM++YzhI6v/L1BWc/kPgxuE3OV87Re+0TH1iLWJ9I727p8KzMhKQFOfozGFl3uecmY/4pHwbxyrEQmV1FCax1YVq9nJdAUAZ0R8yX2Uk4a/WlyVFrx+G4FDuomebyaI0QFieyS9ittNiTN5Yb9e+Vn7t/1GoXK9xm7g0lAM0tf4FzyLHybrsMOGMg9HwxlTmeC4QhHYHsrV4WP2gYYelAA8x7/aRv02cmEFBQWs+3HhqLirZ/sPPAa3ON0I6ign9JRqKGBtrTi55fS9DIvvHxwL12+YzbUqCqIgGgsaTQ28arxHoszzaE+FYO/Nv9IMFTQ=
X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:BYAPR12MB4597.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(4636009)(39860400002)(346002)(376002)(396003)(136003)(366004)(26005)(186003)(8676002)(478600001)(6666004)(5660300002)(8936002)(16526019)(6486002)(53546011)(6506007)(66946007)(2906002)(31686004)(83380400001)(52116002)(36756003)(31696002)(66556008)(66476007)(4326008)(956004)(2616005)(44832011)(316002)(86362001)(6512007)(41533002)(43740500002);DIR:OUT;SFP:1101;
X-MS-Exchange-AntiSpam-MessageData: hwuXdJ3BD8ATCAVyCHeUQaxLzW7ZXYwW1lcwlpj7hwrQnYkVsVat7Ru1yCHJHv6eZ/+8qETuknjT4EyiOShJGOh7oWNorWcE8mYo2a4JtJG3WgGn+14iBTGGVLeFcxyL+KwfJBGKCBj9Y5e/hlfWCNCxnqflIq91IoXo0pH++bYzp5Su0Um25hLDQBUdPmtm9OeR5pTDZYWJmiLh9SCiEHzSbqmxuCPr2Q82QdHAxidElSDm1v4lOdpM9d3R1Ejalxy6aJj3mTjaguGPtvOzgDsEpG37nLCZJWpyDJ0N9L/bfJt4xKxXzr/TJvN0XBZuh05qreFECzdugTwlUEDhYXXBU/bMUVKNHTDkHb0uJq9lFsbBzaL4YWYAMSBfKhpmSSvt3oVr44xvlUvmk//W5NlGlafMbeg72yblz6kb/Q7zEUwflfI/fVlCFZwfdfPeVJ12JvnO7l0ZhBQhTtZ+DahFImK6alRvlxRlGY/S3xc8EEjafLocIhbCsvLU7ekedvByjQwsPxtz3r8WAIKlNnr/FJq/cR215ILXY5uYG6RsQJpN/g6zJWLQYMs4eOJIpBWhJ0BbgposURILEZ2HFir6hWA8uBEki/1VupNxpxxROu2b/PMsgVvGSvuQvjZf8CN+cYyQXMB+7exOSFmefg==
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: ef0c667f-1d99-4c0d-9905-08d87eddb0a6
X-MS-Exchange-CrossTenant-AuthSource: BYAPR12MB4597.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Nov 2020 03:16:29.1794
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: AfTUIV4MO88Y/fygcMDEfYS+bQ27uh/TJ+F90m9jO23yiNGdk1Ly8KURTPjCBJ+OTNGrVDENrypkNrGuLzcSUA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BY5PR12MB4161
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Joerg,

You mentioned to remind you to pull this in to linux-next.

Thanks,
Suravee

On 10/4/20 8:45 AM, Suravee Suthikulpanit wrote:
> The framework allows callable implementation of IO page table.
> This allows AMD IOMMU driver to switch between different types
> of AMD IOMMU page tables (e.g. v1 vs. v2).
> 
> This series refactors the current implementation of AMD IOMMU v1 page table
> to adopt the framework. There should be no functional change.
> Subsequent series will introduce support for the AMD IOMMU v2 page table.
> 
> Thanks,
> Suravee
> 
> Change from V2 (https://lore.kernel.org/lkml/835c0d46-ed96-9fbe-856a-777dcffac967@amd.com/T/#t)
>    - Patch 2/14: Introduce helper function io_pgtable_cfg_to_data.
>    - Patch 13/14: Put back the struct iommu_flush_ops since patch v2 would run into
>      NULL pointer bug when calling free_io_pgtable_ops if not defined.
> 
> Change from V1 (https://lkml.org/lkml/2020/9/23/251)
>    - Do not specify struct io_pgtable_cfg.coherent_walk, since it is
>      not currently used. (per Robin)
>    - Remove unused struct iommu_flush_ops.  (patch 2/13)
>    - Move amd_iommu_setup_io_pgtable_ops to iommu.c instead of io_pgtable.c
>      patch 13/13)
> 
> Suravee Suthikulpanit (14):
>    iommu/amd: Re-define amd_iommu_domain_encode_pgtable as inline
>    iommu/amd: Prepare for generic IO page table framework
>    iommu/amd: Move pt_root to to struct amd_io_pgtable
>    iommu/amd: Convert to using amd_io_pgtable
>    iommu/amd: Declare functions as extern
>    iommu/amd: Move IO page table related functions
>    iommu/amd: Restructure code for freeing page table
>    iommu/amd: Remove amd_iommu_domain_get_pgtable
>    iommu/amd: Rename variables to be consistent with struct
>      io_pgtable_ops
>    iommu/amd: Refactor fetch_pte to use struct amd_io_pgtable
>    iommu/amd: Introduce iommu_v1_iova_to_phys
>    iommu/amd: Introduce iommu_v1_map_page and iommu_v1_unmap_page
>    iommu/amd: Introduce IOMMU flush callbacks
>    iommu/amd: Adopt IO page table framework
> 
>   drivers/iommu/amd/Kconfig           |   1 +
>   drivers/iommu/amd/Makefile          |   2 +-
>   drivers/iommu/amd/amd_iommu.h       |  22 +
>   drivers/iommu/amd/amd_iommu_types.h |  43 +-
>   drivers/iommu/amd/io_pgtable.c      | 564 ++++++++++++++++++++++++
>   drivers/iommu/amd/iommu.c           | 646 +++-------------------------
>   drivers/iommu/io-pgtable.c          |   3 +
>   include/linux/io-pgtable.h          |   2 +
>   8 files changed, 691 insertions(+), 592 deletions(-)
>   create mode 100644 drivers/iommu/amd/io_pgtable.c
>