Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201030072444.22122-1-zhang.lyra@gmail.com> <20201030134227.GC4405@sirena.org.uk>
In-Reply-To: <20201030134227.GC4405@sirena.org.uk>
From:   Chunyan Zhang <zhang.lyra@gmail.com>
Date:   Mon, 2 Nov 2020 11:17:30 +0800
Message-ID: <CAAfSe-sTUptZKq9v8MqW247cXPnh__QKmNe9+M458owtB82Pfg@mail.gmail.com>
Subject: Re: [PATCH] spi: sprd: add runtime pm for transfer message
To:     Mark Brown <broonie@kernel.org>
Cc:     linux-spi@vger.kernel.org,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        Bangzheng Liu <bangzheng.liu@unisoc.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Fri, 30 Oct 2020 at 21:42, Mark Brown <broonie@kernel.org> wrote:
>
> On Fri, Oct 30, 2020 at 03:24:44PM +0800, Chunyan Zhang wrote:
> > From: Bangzheng Liu <bangzheng.liu@unisoc.com>
> >
> > Before transfer one message, spi core would set chipselect, sprd spi
> > device should be resumed from runtime suspend, otherwise kernel would
> > crash once access spi registers. The sprd spi device can be suspended
> > until clearing chipselect which would be executed after transfer.
>
> The core should be handling runtime PM for normal transfers, if it's not
> managing to do that then we should fix the core so it's fixed for all
> drivers not just this one.

Sure, I will send a new patch.