Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3022766pxx; Sun, 1 Nov 2020 19:43:10 -0800 (PST) X-Google-Smtp-Source: ABdhPJx8ueY+a9qOeH9LwAXq1jrb+aIoPt8auGJe7KydvR5zMjVEPvhZ+kUDi9vB40q46OuqUZo1 X-Received: by 2002:a17:906:1c0f:: with SMTP id k15mr13048062ejg.343.1604288590729; Sun, 01 Nov 2020 19:43:10 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604288590; cv=none; d=google.com; s=arc-20160816; b=IfWLm/m2yB9uQZN3KD/2CTtpOkK5c5dVQZGyujn++kg07LVc1cvjrK4laUuROcSuyC 6/AG3imfXff2ybrvl59NqFKKJs22l6k9t/hYAfCfsmt3uvtthsRw4b7wAWsT2dO+QSPC B4wiGVqmrHCbNb/G9KrAUK4hDP2iQAscZbnRQqbzUkcu+dWHBO7BbD+YTmbUEtEQI0JC R+xU2PUYc5bFgkv6g2NrreQkS8x78JtUEDTxgUIm7+WRoosWog//EzAZrwBzLwQoPGmw wf2uGwjGy6muyXTyHVYaAjOSeJu4k/xD8neBTDvCxlSOnpBjxEC8akr+3DzmidzID40Z V15Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:user-agent:in-reply-to:content-disposition :mime-version:references:message-id:subject:cc:to:from:date; bh=hHRAaUrH8GgoPtOi6nVaUvTL0mQpvvIkg77vuUwRb8w=; b=SlGLjsH63sjO7Iofp6kgAaSHmk3EY0wtrDkebxD0NBTey4UVPnFLYyK+GEPnfsqgS5 rmZPj31dMBtTpIUPcbikGQ9/xcyDC5R6hFgUguYLpn99H/hQ0EiSI92/hQif6UCsn1rc 6mwEh0tFf2tgbNnLFKlOhbtmJWuZ4omFVxn/gFLCG6u+FmZ5hnJUxkY2E4vFVBf7jGqj O2rjrGgDcvBu/qZq9czaw3VA5OE+c2VuYCyQSfePlqJBjnjw/oayyJdu4v78PatyqhWG eC4JUk28ZABMcZBYqsAS4MNKLpZVhlp9TIkuviVFhTl/AhOXBtVS6nHlTAu/uZjZfwyK QW7w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id z20si9153070eji.649.2020.11.01.19.42.33; Sun, 01 Nov 2020 19:43:10 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727806AbgKBDi6 (ORCPT + 99 others); Sun, 1 Nov 2020 22:38:58 -0500 Received: from helcar.hmeau.com ([216.24.177.18]:41944 "EHLO fornost.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727470AbgKBDi6 (ORCPT ); Sun, 1 Nov 2020 22:38:58 -0500 Received: from gwarestrin.arnor.me.apana.org.au ([192.168.0.7]) by fornost.hmeau.com with smtp (Exim 4.92 #5 (Debian)) id 1kZQgC-00072h-Gs; Mon, 02 Nov 2020 14:38:49 +1100 Received: by gwarestrin.arnor.me.apana.org.au (sSMTP sendmail emulation); Mon, 02 Nov 2020 14:38:48 +1100 Date: Mon, 2 Nov 2020 14:38:48 +1100 From: Herbert Xu To: Alistair Delva Cc: Dmitry Safonov <0x7f454c46@gmail.com>, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Jakub Kicinski , "David S . Miller" , kernel-team@android.com, Maciej =?utf-8?Q?=C5=BBenczykowski?= , Steffen Klassert Subject: Re: [PATCH] xfrm/compat: Remove use of kmalloc_track_caller Message-ID: <20201102033848.GA1861@gondor.apana.org.au> References: <20201101220845.2391858-1-adelva@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201101220845.2391858-1-adelva@google.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Nov 01, 2020 at 02:08:45PM -0800, Alistair Delva wrote: > The __kmalloc_track_caller symbol is not exported if SLUB/SLOB are > enabled instead of SLAB, which breaks the build on such configs when > CONFIG_XFRM_USER_COMPAT=m. > > ERROR: "__kmalloc_track_caller" [net/xfrm/xfrm_compat.ko] undefined! Is this with a recent kernel? Because they should be exported: commit fd7cb5753ef49964ea9db5121c3fc9a4ec21ed8e Author: Daniel Vetter Date: Mon Mar 23 15:49:00 2020 +0100 mm/sl[uo]b: export __kmalloc_track(_node)_caller Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt