Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH] serial: mctrl_gpio: Fix passing zero to 'ERR_PTR' warning
To:     YueHaibing <yuehaibing@huawei.com>, gregkh@linuxfoundation.org
Cc:     linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20201031030530.1304-1-yuehaibing@huawei.com>
From:   Jiri Slaby <jirislaby@kernel.org>
Message-ID: <e8d9c560-dfd4-8419-a768-6a832114e7ea@kernel.org>
Date:   Mon, 2 Nov 2020 09:20:34 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.3.3
MIME-Version: 1.0
In-Reply-To: <20201031030530.1304-1-yuehaibing@huawei.com>
Content-Type: text/plain; charset=iso-8859-2; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 31. 10. 20, 4:05, YueHaibing wrote:
> drivers/tty/serial/serial_mctrl_gpio.c:214
>   mctrl_gpio_init() warn: passing zero to 'ERR_PTR'
> 
> gpiod_to_irq() never return 0, so remove the useless test
> and make code more clear.
> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Reviewed-by: Jiri Slaby <jirislaby@kernel.org>

> ---
>   drivers/tty/serial/serial_mctrl_gpio.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/serial_mctrl_gpio.c b/drivers/tty/serial/serial_mctrl_gpio.c
> index fb4781292d40..c41d8911ce95 100644
> --- a/drivers/tty/serial/serial_mctrl_gpio.c
> +++ b/drivers/tty/serial/serial_mctrl_gpio.c
> @@ -207,7 +207,7 @@ struct mctrl_gpios *mctrl_gpio_init(struct uart_port *port, unsigned int idx)
>   			continue;
>   
>   		ret = gpiod_to_irq(gpios->gpio[i]);
> -		if (ret <= 0) {
> +		if (ret < 0) {
>   			dev_err(port->dev,
>   				"failed to find corresponding irq for %s (idx=%d, err=%d)\n",
>   				mctrl_gpios_desc[i].name, idx, ret);
> 


-- 
js
suse labs