Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH -next] drm/panfrost: Fix unused variable warning
To:     Zou Wei <zou_wei@huawei.com>, robh@kernel.org,
        tomeu.vizoso@collabora.com, alyssa.rosenzweig@collabora.com,
        airlied@linux.ie, daniel@ffwll.ch
Cc:     dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org
References: <1604309599-10078-1-git-send-email-zou_wei@huawei.com>
From:   Steven Price <steven.price@arm.com>
Message-ID: <8729ad8d-31db-c7cd-e962-a0f7db6891b3@arm.com>
Date:   Mon, 2 Nov 2020 09:29:08 +0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <1604309599-10078-1-git-send-email-zou_wei@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-GB
Content-Transfer-Encoding: 8bit
Precedence: bulk

On 02/11/2020 09:33, Zou Wei wrote:
> Fixes the following W=1 kernel build warning:
> 
> ./panfrost_job.c:617:28: warning: unused variable ‘js’ [-Wunused-variable]
>    struct panfrost_job_slot *js = pfdev->js;
>                              ^~
> 
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>

Boris posted an identical patch earlier:

https://lore.kernel.org/r/20201101173817.831769-1-boris.brezillon%40collabora.com

Steve

> ---
>   drivers/gpu/drm/panfrost/panfrost_job.c | 2 --
>   1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/panfrost/panfrost_job.c b/drivers/gpu/drm/panfrost/panfrost_job.c
> index 4902bc6..e75b7d2 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_job.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_job.c
> @@ -613,8 +613,6 @@ int panfrost_job_open(struct panfrost_file_priv *panfrost_priv)
>   
>   void panfrost_job_close(struct panfrost_file_priv *panfrost_priv)
>   {
> -	struct panfrost_device *pfdev = panfrost_priv->pfdev;
> -	struct panfrost_job_slot *js = pfdev->js;
>   	int i;
>   
>   	for (i = 0; i < NUM_JOB_SLOTS; i++)
>