Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3170563pxx; Mon, 2 Nov 2020 01:42:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJwknkJd14dj2qEd2TzGB0QMb1bTlKMRhk2T5OJ/WywQ7FyeWvKGihuyOKj2yKq9/iIT+liJ X-Received: by 2002:a05:6402:1cb2:: with SMTP id cz18mr214941edb.388.1604310166470; Mon, 02 Nov 2020 01:42:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604310166; cv=none; d=google.com; s=arc-20160816; b=pjenwVqVjzjxN3Mf8IYZsSvL3JJ4RylxnEM9iLeeQ6iR1cIhEiecpWe4vCAUyP66E8 yZhemVUz5Ud+R9PUG+8/+5a2Lnl8rTpBVDAXXDjI8kWedLhTcg9BDaP6vxeHOC9YwH0D Dr9UznmAB97x2zE5AkhBVCDLzohX2Nj+RdN9+MUiAv5Esqvt8m3hHemvFfcS4CQxV8F8 snFyQooafk/TUAmH0BeDG5aMNFrtAnIsIkBmr4muMYFeGEcDF2V9CrppR6MkXmujgnHG eUC6Cd/1dJr2IWW09VHOpIAFMwh5pFszGkll1gm5Q+sR3RVyHzLew1HBjbey8KO0H4ZR VcdQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:references:in-reply-to:message-id :date:subject:to:from; bh=DYatrCACe+pPheBkYYw4yh6fCo6YIvtEL31jZQLm7gs=; b=VB3tj8+P1QDJZc1BOK91eltbr85EdktkI8yCQMDgcTKBTy9HZpvdNtOansGGMRNkt4 18U5fmxutitH38dFQzy7I325/0Vd/GYnwrk7KIGCsk46Xf5fY7RZwo5oBqT9EupRWnYD 0fhs8LalG+e59cVmcdfLi19sgUYVWa9znvTAXzbiplr2DdWA3nV3/hxwxdUEpegh+hzT TRWSJJeCaoYA5oIuxZtLfHWo+RIBOLcD6vpjKIJGZnhJ15dKc6Xm4YdPWiKqdBbGL9TW sH3anbHizsVZio17ESnIrtc1xNXWnFKV9uTA76023J4SMfh4jiYRUnzd8Dk/8REwCZFP PnCg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l10si10132814edv.73.2020.11.02.01.42.24; Mon, 02 Nov 2020 01:42:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728345AbgKBJlC (ORCPT + 99 others); Mon, 2 Nov 2020 04:41:02 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:6731 "EHLO szxga04-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728297AbgKBJlB (ORCPT ); Mon, 2 Nov 2020 04:41:01 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4CPnwR4xg0zkdXT; Mon, 2 Nov 2020 17:40:55 +0800 (CST) Received: from huawei.com (10.67.165.24) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.487.0; Mon, 2 Nov 2020 17:40:51 +0800 From: Kai Ye To: , , , , Subject: [RESEND PATCH v3 1/2] uacce: delete some redundant code. Date: Mon, 2 Nov 2020 17:39:24 +0800 Message-ID: <1604309965-21752-2-git-send-email-yekai13@huawei.com> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1604309965-21752-1-git-send-email-yekai13@huawei.com> References: <1604309965-21752-1-git-send-email-yekai13@huawei.com> MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.67.165.24] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Delete some redundant code. Signed-off-by: Kai Ye Reviewed-by: Zhou Wang Reviewed-by: Jonathan Cameron Acked-by: Zhangfei Gao --- drivers/misc/uacce/uacce.c | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/drivers/misc/uacce/uacce.c b/drivers/misc/uacce/uacce.c index 56dd98a..eb827f1 100644 --- a/drivers/misc/uacce/uacce.c +++ b/drivers/misc/uacce/uacce.c @@ -231,17 +231,6 @@ static int uacce_fops_mmap(struct file *filep, struct vm_area_struct *vma) switch (type) { case UACCE_QFRT_MMIO: - if (!uacce->ops->mmap) { - ret = -EINVAL; - goto out_with_lock; - } - - ret = uacce->ops->mmap(q, vma, qfr); - if (ret) - goto out_with_lock; - - break; - case UACCE_QFRT_DUS: if (!uacce->ops->mmap) { ret = -EINVAL; -- 2.8.1