Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 2 Nov 2020 11:13:33 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Paul Kocialkowski <contact@paulk.fr>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Matteo Scordino <matteo.scordino@gmail.com>,
        Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179
 bindings
Message-ID: <20201102101333.4bm2lfqpqnbpyp63@gilmour.lan>
References: <20201031182137.1879521-1-contact@paulk.fr>
 <20201031182137.1879521-9-contact@paulk.fr>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="vt3swrzx5fe4gwkc"
Content-Disposition: inline
In-Reply-To: <20201031182137.1879521-9-contact@paulk.fr>
Precedence: bulk


--vt3swrzx5fe4gwkc
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Oct 31, 2020 at 07:21:36PM +0100, Paul Kocialkowski wrote:
> Document the compatible strings for the SL631 Action Camera with IMX179.
>=20
> Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> ---
>  Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
>=20
> diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Documenta=
tion/devicetree/bindings/arm/sunxi.yaml
> index afa00268c7db..0fa0c0b5d89f 100644
> --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> @@ -754,6 +754,12 @@ properties:
>            - const: sinlinx,sina33
>            - const: allwinner,sun8i-a33
> =20
> +      - description: SL631 Action Camera with IMX179
> +        items:
> +          - const: unknown,sl631-imx179
> +          - const: unknown,sl631
> +          - const: allwinner,sun8i-v3
> +

unknown is not a valid vendor (and you should explain why you picked
that vendor name in the first place).

Maxime

--vt3swrzx5fe4gwkc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX5/bzAAKCRDj7w1vZxhR
xXlTAQCtakHTsGL/lVoBZ1D8Kq6UBKteAITkBi70XtnFzEBIRwEA5bgkK47Hz68b
67T12Nx1hbPxUVCc2JxhuQh5ldvWiAo=
=DSmd
-----END PGP SIGNATURE-----

--vt3swrzx5fe4gwkc--