Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3220294pxx; Mon, 2 Nov 2020 03:21:44 -0800 (PST) X-Google-Smtp-Source: ABdhPJw62p7S7w6AEoyyN6zq9MyFoRzde1+H+LZtVq9SrjNz+eVSdidTGEBJKpmniF8WY3KFcLJF X-Received: by 2002:a50:8745:: with SMTP id 5mr15807153edv.49.1604316104526; Mon, 02 Nov 2020 03:21:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604316104; cv=none; d=google.com; s=arc-20160816; b=Nw/W2kavwbDVepDq4Z8YPwmKIQaPE9CelkPnG1B2+SOIBygheYjcpygZqsoAC3X0of G1rX3gL+1LGMcYCcnPl3dgnnztEX8i5DYdqQqgdnd9XYb2e8M/P6aIowl4WuIoU1AQDt fdq3VYC00rgIYrLyRlPNv7wZ7PXLwZMZzDjkziqGZuqbpdJnwm4ClEprCTwELpOfsBwO wjkdzz5n5pB1Jp8nzG+jfw+pCm+iCylpHMWYeNoy80BPPDs1ONiB6+Yi44uK+pIIH34v 5ZA7F9DOhrfwNuxsI58D6qVRJqiZm0xpTy/TBEK+GPFXFQtJ3AH3pB88/uchP8Hozw5K yBUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=GhkGIFuPCQH1ApZ0OEdak3cupRfMDnYm6i9v+8WlGe4=; b=jYjGeyL4u+lxT/9VLW7HTIMO+hulGOn4af1jHksFfg2i1vYeQui7wQpNEMYzelK+OC YeKW79xxGZ2Azzb2q/FhEP2DDviIZSSxHfRG7Wiz/nES/XneOpS354Q02EM0NE6AX6ZS MItE26wMYXBQKTVXRtBZ29B/ZiK7m61CUwLHtO1nUUce9Jczgc6nVuElZHtv/H/dwgMv xATAPvHzVpjYX/PYlhj8ykqWVOQx0h7JFxmdHRmtfuXDBU3VzPDzz+9jXghVr1eti6+Y N2qQy5TuMe3qee350zagk0ipuEqr/JF7dNNgOXDrQgbIF7NdbrEg6yRWzrCSpULwj56I NGqA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="RGm0D/az"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dh19si270791edb.148.2020.11.02.03.21.22; Mon, 02 Nov 2020 03:21:44 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="RGm0D/az"; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728487AbgKBLRj (ORCPT + 99 others); Mon, 2 Nov 2020 06:17:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46806 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728479AbgKBLRd (ORCPT ); Mon, 2 Nov 2020 06:17:33 -0500 Received: from mail-ej1-x641.google.com (mail-ej1-x641.google.com [IPv6:2a00:1450:4864:20::641]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 663F8C0617A6; Mon, 2 Nov 2020 03:17:32 -0800 (PST) Received: by mail-ej1-x641.google.com with SMTP id dk16so17777797ejb.12; Mon, 02 Nov 2020 03:17:32 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=GhkGIFuPCQH1ApZ0OEdak3cupRfMDnYm6i9v+8WlGe4=; b=RGm0D/azCDx/+F9Bxtb05bsbLj63EOhboPhK1LtfSVIBdpy6By7w6EHObeFCl1xOfX L5MnL2//34WM0z++cSQNa4pn170lNHiOIFn/kv90RoYKiLtKoPH4/0Hfr6eWjwCuDLo2 NuV3bsM3jUdJA/mT6hKjSa70HZxRuhfuTlcTzCedxqvxR9KVfvaKBaBxNn3stIl0XqfV aEWlwDxRMUPCzqeoVQjvTly8UNSqCsF9mepnxc40s6iM5/w5QCNZo0R4c84x8vccpaIn jb7ivJjc1zr/U2oiAJobsF5CAZJF8mqQf/pM0grDdSLtBXNXtwoYMSbd9GT664BOt5kG 3UIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=GhkGIFuPCQH1ApZ0OEdak3cupRfMDnYm6i9v+8WlGe4=; b=P3DhdroNWJZ17RPmkPxDsDCn6UAyoEFmyR1WKpCkSB1aoGveyd3f+b2cZydrZhH2qA PZKNDiCaG+KUcO48pbcrbsTV+K1OBfTm9OVnGj13WIqMl0XFM0dNMZVyCEnc9IQ4daPp ebjK1l7q6tYI9OO6Kh+wg65tMioda63uqjFgkjO7gIM2EO//DBh9RO8ybCNGe8sXa7wQ fNH2j2pHvLuuCzrafy5vNkQhsSw2bc+5pMc4eTYVNunIoAqW0lE4W2r3RDWwwtauew9R vO5wPoa337pDMYo3kvG70NtAjTG7RgO22c+SIOeV1Xzacty8Cy35T4aCkIgoKhYJsmay oa1Q== X-Gm-Message-State: AOAM532NQC8v+KniaCaClMpW2dSVIcDovdMCFLOywtbcaiBANlqgg9Kt lBKqCSftL2tBZZlq9ncoTsKWL2eOcq4= X-Received: by 2002:a17:906:c8d8:: with SMTP id gc24mr5556078ejb.417.1604315851176; Mon, 02 Nov 2020 03:17:31 -0800 (PST) Received: from skbuf ([188.25.2.177]) by smtp.gmail.com with ESMTPSA id pw17sm9481559ejb.116.2020.11.02.03.17.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:17:30 -0800 (PST) Date: Mon, 2 Nov 2020 13:17:29 +0200 From: Vladimir Oltean To: Qiang Zhao Cc: "broonie@kernel.org" , "linux-spi@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] spi: fsl-dspi: fix NULL pointer dereference Message-ID: <20201102111729.psxu6cx2mccbtra2@skbuf> References: <20201029084035.19604-1-qiang.zhao@nxp.com> <20201030131828.7h25eps7wuf655eh@skbuf> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 02, 2020 at 02:19:28AM +0000, Qiang Zhao wrote: > How about it looks like below: > > spi: fsl-dspi: fix wrong pointer in suspend/resume > > Since commit 530b5affc675 ("spi: fsl-dspi: fix use-after-free in > remove path"), this driver causes a "NULL pointer dereference" > in dspi_suspend/resume. > This is because since this commit, the drivers private data point to > "dspi" instead of "ctlr", the codes in suspend and resume func were > not modified correspondly. Looks ok.