Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3238805pxx; Mon, 2 Nov 2020 03:57:25 -0800 (PST) X-Google-Smtp-Source: ABdhPJzeqW+TUfcWs/+ulg8lnJ6h+M47L+ghyIv8PedmLMoKnYxgi3mnUmfNdVDV8USTkQMRLv5w X-Received: by 2002:a50:cc48:: with SMTP id n8mr16492027edi.137.1604318245248; Mon, 02 Nov 2020 03:57:25 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604318245; cv=none; d=google.com; s=arc-20160816; b=OpdIEBDtiB5Wbc/3ZEiYF1UWR17KvXJLz5nylB7TQD8QaRz3M6avwLjF8rK+boXUVw 7l7sscj4hcPD6MD6Sno2Pkm174736tNz6JrPo2qKHB8NWjDOBKbLqzO4vP0doNipQ2C9 w6qFMa8ntaRzOcbbCFEoCaG+fK4s7jMTJcb4GdvKMY8Ydc5/b9rz/GfS76UgILJ11QFn kUbjqHLZ5NYWzcXvNbucwCixraiOx116wQQO79fSeqowvDa4dZQebThyyKP6kPxHVWVa Dc+bDWFzs02hVUqRNu92hqB7X7p+iHhzYCI6OXD52ey3LPriFtJqMGL1yyoHCxy0lbi8 uy6A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=TuX3K0j4y5py35J7qAVJzMeaaIIyoaLFFbYRmFexlrI=; b=vw2nsFWIN+XYSGELNKAPtgTkYBmeTtPY1fXocdDypPNFrz36Puk8yuHCE2irZe0Anu 7TrNOyIWUcEOSlpf+Tx3xo64PMRbtf4+Y8oRv4nB2hMYa0CyHjcWb4TJp/Z5+af8WVRe PUrqkebS4xT+kiP55L6SHaYCStRY7kLW56Y8TM414O85ByNdImsLW7e7UPjUL2wORiSA bqnhfYMUREb4qvbIUMFsC1jITkfTd977Z0tVRUdNyxuSKvhYknzDHoVg2PtlWZ9ecMKF e6JpkA2SwsDyIAo+/y3+9SgW/rA8JSO7BxN2ic0CDfnRIu88L9qa/F6w7PBTBja5Ddcs YSWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Iii8iIXF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e7si10639929edu.247.2020.11.02.03.57.01; Mon, 02 Nov 2020 03:57:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=Iii8iIXF; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728610AbgKBLzD (ORCPT + 99 others); Mon, 2 Nov 2020 06:55:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52940 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728652AbgKBLyj (ORCPT ); Mon, 2 Nov 2020 06:54:39 -0500 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80FA3C0617A6 for ; Mon, 2 Nov 2020 03:54:38 -0800 (PST) Received: by mail-wr1-x443.google.com with SMTP id b8so14283243wrn.0 for ; Mon, 02 Nov 2020 03:54:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=TuX3K0j4y5py35J7qAVJzMeaaIIyoaLFFbYRmFexlrI=; b=Iii8iIXFz3DaP8nBi80kVmkd0bNqhbz3hOwZ0JAgeSDj+ym7hsWQII9Jw99dOraG5X tmxMuDtVnQVfF/PgryImz3XyitN1xI+MWhG4G+QhCqazJ3M8NqVRYPKllLpURJQC7IIk /Qh8H948PpmTgd3wGCxyeMi2vptbnlJbf9qwudoND2ktnCrdyLw8x4+WPlOR92qfff6t MGEhk8463TPQkH84ONyGrS69oSglz3jJYZA2cRNSNV27dtyYwTifKXiNSySDjPBeKLkR ws9R3MpPV98EczJnIgIctrHj5l1A0fB06BS2qJKK/i4yF87MIxXSq1fci/XAsUrCkObp etSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=TuX3K0j4y5py35J7qAVJzMeaaIIyoaLFFbYRmFexlrI=; b=csvvw1gqkbpaDJCmFk5gQ8oyBhK69uIZvP5vL2fo4yUKlVuv+3li3w0hzj91HaGfFz kByJuDTQJp3S9/kAh3oA8g47jNb1Hydp1EGYUHMFDsHt0pS3U7q7TIHLaWDNA0q37DKt CxbVkebMoT8CfObdd+APG6vRCO4Jg3jljIRkfsPLSkaRZFhbUU19n7EuMYHsOpabYdJd LzVgwf4hKUpAehjCGcyJRtDRdpEXuBIzw4wQiFwUG50UBFNXoIvpsMgwsZubewKTQITd do7S7PV+H86fDcAgLKxaWCvWHxTvDiuruOJGkTkvz2w62E+MX6OdI6hFh3B0AJyb5aUK wnSA== X-Gm-Message-State: AOAM532X+3PN7g1M9Bka6Cthw9De+y/9Mv2RdzsR63rf0OILOcaVbN25 AZ2uEHMJ7hkQi7nFPJVfbed6MQ== X-Received: by 2002:a5d:4207:: with SMTP id n7mr19616409wrq.76.1604318077273; Mon, 02 Nov 2020 03:54:37 -0800 (PST) Received: from dell.default ([91.110.221.242]) by smtp.gmail.com with ESMTPSA id t23sm14284010wmn.13.2020.11.02.03.54.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 03:54:36 -0800 (PST) From: Lee Jones To: vigneshr@ti.com Cc: linux-kernel@vger.kernel.org, Lee Jones , Miquel Raynal , Richard Weinberger , Jian Zhang , linux-mtd@lists.infradead.org Subject: [PATCH 19/23] mtd: nand: raw: omap2: Fix a bunch of kernel-doc misdemeanours Date: Mon, 2 Nov 2020 11:54:02 +0000 Message-Id: <20201102115406.1074327-20-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20201102115406.1074327-1-lee.jones@linaro.org> References: <20201102115406.1074327-1-lee.jones@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Fixes the following W=1 kernel build warning(s): drivers/mtd/nand/raw/omap2.c:191: warning: Function parameter or member 'info' not described in 'omap_prefetch_enable' drivers/mtd/nand/raw/omap2.c:221: warning: Function parameter or member 'cs' not described in 'omap_prefetch_reset' drivers/mtd/nand/raw/omap2.c:221: warning: Function parameter or member 'info' not described in 'omap_prefetch_reset' drivers/mtd/nand/raw/omap2.c:946: warning: Function parameter or member 'chip' not described in 'omap_enable_hwecc' drivers/mtd/nand/raw/omap2.c:946: warning: Excess function parameter 'mtd' description in 'omap_enable_hwecc' drivers/mtd/nand/raw/omap2.c:1017: warning: Function parameter or member 'chip' not described in 'omap_dev_ready' drivers/mtd/nand/raw/omap2.c:1017: warning: Excess function parameter 'mtd' description in 'omap_dev_ready' drivers/mtd/nand/raw/omap2.c:1036: warning: Function parameter or member 'chip' not described in 'omap_enable_hwecc_bch' drivers/mtd/nand/raw/omap2.c:1036: warning: Excess function parameter 'mtd' description in 'omap_enable_hwecc_bch' drivers/mtd/nand/raw/omap2.c:1142: warning: Function parameter or member 'ecc_calc' not described in '_omap_calculate_ecc_bch' drivers/mtd/nand/raw/omap2.c:1142: warning: Excess function parameter 'ecc_code' description in '_omap_calculate_ecc_bch' drivers/mtd/nand/raw/omap2.c:1270: warning: Function parameter or member 'ecc_calc' not described in 'omap_calculate_ecc_bch_sw' drivers/mtd/nand/raw/omap2.c:1270: warning: Excess function parameter 'ecc_code' description in 'omap_calculate_ecc_bch_sw' drivers/mtd/nand/raw/omap2.c:1284: warning: Function parameter or member 'ecc_calc' not described in 'omap_calculate_ecc_bch_multi' drivers/mtd/nand/raw/omap2.c:1284: warning: Excess function parameter 'ecc_code' description in 'omap_calculate_ecc_bch_multi' drivers/mtd/nand/raw/omap2.c:1681: warning: Function parameter or member 'info' not described in 'is_elm_present' drivers/mtd/nand/raw/omap2.c:1681: warning: Function parameter or member 'elm_node' not described in 'is_elm_present' drivers/mtd/nand/raw/omap2.c:1681: warning: Excess function parameter 'omap_nand_info' description in 'is_elm_present' Cc: Miquel Raynal Cc: Richard Weinberger Cc: Vignesh Raghavendra Cc: Jian Zhang Cc: linux-mtd@lists.infradead.org Signed-off-by: Lee Jones --- drivers/mtd/nand/raw/omap2.c | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/drivers/mtd/nand/raw/omap2.c b/drivers/mtd/nand/raw/omap2.c index 4cc47ab7f01ad..b5a2d8971bfdd 100644 --- a/drivers/mtd/nand/raw/omap2.c +++ b/drivers/mtd/nand/raw/omap2.c @@ -184,6 +184,7 @@ static inline struct omap_nand_info *mtd_to_omap(struct mtd_info *mtd) * @dma_mode: dma mode enable (1) or disable (0) * @u32_count: number of bytes to be transferred * @is_write: prefetch read(0) or write post(1) mode + * @info: NAND device structure containing platform data */ static int omap_prefetch_enable(int cs, int fifo_th, int dma_mode, unsigned int u32_count, int is_write, struct omap_nand_info *info) @@ -213,7 +214,7 @@ static int omap_prefetch_enable(int cs, int fifo_th, int dma_mode, return 0; } -/** +/* * omap_prefetch_reset - disables and stops the prefetch engine */ static int omap_prefetch_reset(int cs, struct omap_nand_info *info) @@ -938,7 +939,7 @@ static int omap_calculate_ecc(struct nand_chip *chip, const u_char *dat, /** * omap_enable_hwecc - This function enables the hardware ecc functionality - * @mtd: MTD device structure + * @chip: NAND chip object * @mode: Read/Write mode */ static void omap_enable_hwecc(struct nand_chip *chip, int mode) @@ -1008,7 +1009,7 @@ static int omap_wait(struct nand_chip *this) /** * omap_dev_ready - checks the NAND Ready GPIO line - * @mtd: MTD device structure + * @chip: NAND chip object * * Returns true if ready and false if busy. */ @@ -1021,7 +1022,7 @@ static int omap_dev_ready(struct nand_chip *chip) /** * omap_enable_hwecc_bch - Program GPMC to perform BCH ECC calculation - * @mtd: MTD device structure + * @chip: NAND chip object * @mode: Read/Write mode * * When using BCH with SW correction (i.e. no ELM), sector size is set @@ -1130,7 +1131,7 @@ static u8 bch8_polynomial[] = {0xef, 0x51, 0x2e, 0x09, 0xed, 0x93, 0x9a, 0xc2, * _omap_calculate_ecc_bch - Generate ECC bytes for one sector * @mtd: MTD device structure * @dat: The pointer to data on which ecc is computed - * @ecc_code: The ecc_code buffer + * @ecc_calc: The ecc_code buffer * @i: The sector number (for a multi sector page) * * Support calculating of BCH4/8/16 ECC vectors for one sector @@ -1258,7 +1259,7 @@ static int _omap_calculate_ecc_bch(struct mtd_info *mtd, * omap_calculate_ecc_bch_sw - ECC generator for sector for SW based correction * @chip: NAND chip object * @dat: The pointer to data on which ecc is computed - * @ecc_code: The ecc_code buffer + * @ecc_calc: The ecc_code buffer * * Support calculating of BCH4/8/16 ECC vectors for one sector. This is used * when SW based correction is required as ECC is required for one sector @@ -1274,7 +1275,7 @@ static int omap_calculate_ecc_bch_sw(struct nand_chip *chip, * omap_calculate_ecc_bch_multi - Generate ECC for multiple sectors * @mtd: MTD device structure * @dat: The pointer to data on which ecc is computed - * @ecc_code: The ecc_code buffer + * @ecc_calc: The ecc_code buffer * * Support calculating of BCH4/8/16 ecc vectors for the entire page in one go. */ @@ -1673,7 +1674,8 @@ static int omap_read_page_bch(struct nand_chip *chip, uint8_t *buf, /** * is_elm_present - checks for presence of ELM module by scanning DT nodes - * @omap_nand_info: NAND device structure containing platform data + * @info: NAND device structure containing platform data + * @elm_node: ELM's DT node */ static bool is_elm_present(struct omap_nand_info *info, struct device_node *elm_node) -- 2.25.1