Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Valdis Kletnieks <valdis@vt.edu>
From:   "Valdis =?utf-8?Q?Kl=c4=93tnieks?=" <valdis.kletnieks@vt.edu>
To:     Dong Aisheng <aisheng.dong@nxp.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>
Cc:     linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org
Subject: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1604318525_168427P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Mon, 02 Nov 2020 07:02:05 -0500
Message-ID: <208469.1604318525@turing-police>
Precedence: bulk

--==_Exmh_1604318525_168427P
Content-Type: text/plain; charset=us-ascii

commit 77d8f3068c63ee0983f0b5ba3207d3f7cce11be4 (HEAD)
Author: Dong Aisheng <aisheng.dong@nxp.com>
Date:   Wed Jul 29 16:00:10 2020 +0800

    clk: imx: scu: add two cells binding support

This missed a #include, which results in some nasty errors when
built as a module

  CC [M]  drivers/clk/imx/clk-scu.o
In file included from ./include/linux/device.h:32,
                 from ./include/linux/of_platform.h:9,
                 from drivers/clk/imx/clk-scu.c:11:
./include/linux/device/driver.h:290:1: warning: data definition has no type or storage class
 device_initcall(__driver##_init);
 ^~~~~~~~~~~~~~~
./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver'
  builtin_driver(__platform_driver, platform_driver_register)
  ^~~~~~~~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver'
 builtin_platform_driver(imx_clk_scu_driver);
 ^~~~~~~~~~~~~~~~~~~~~~~
./include/linux/device/driver.h:290:1: error: type defaults to 'int' in declaration of 'device_initcall' [-Werror=implicit-int]
 device_initcall(__driver##_init);
 ^~~~~~~~~~~~~~~
./include/linux/platform_device.h:258:2: note: in expansion of macro 'builtin_driver'
  builtin_driver(__platform_driver, platform_driver_register)
  ^~~~~~~~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver'
 builtin_platform_driver(imx_clk_scu_driver);
 ^~~~~~~~~~~~~~~~~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: warning: parameter names (without types) in function declaration
In file included from ./include/linux/device.h:32,
                 from ./include/linux/of_platform.h:9,
                 from drivers/clk/imx/clk-scu.c:11:
drivers/clk/imx/clk-scu.c:545:25: warning: 'imx_clk_scu_driver_init' defined but not used [-Wunused-function]
 builtin_platform_driver(imx_clk_scu_driver);
                         ^~~~~~~~~~~~~~~~~~
./include/linux/device/driver.h:286:19: note: in definition of macro 'builtin_driver'
 static int __init __driver##_init(void) \
                   ^~~~~~~~
drivers/clk/imx/clk-scu.c:545:1: note: in expansion of macro 'builtin_platform_driver'
 builtin_platform_driver(imx_clk_scu_driver);
 ^~~~~~~~~~~~~~~~~~~~~~~
cc1: some warnings being treated as errors
make[3]: *** [scripts/Makefile.build:283: drivers/clk/imx/clk-scu.o] Error 1

Fix by providing the include.

Signed-off-by: Valdis Kletnieks <valdis.kletnieks@vt.edu>

diff --git a/drivers/clk/imx/clk-scu.c b/drivers/clk/imx/clk-scu.c
index 229a290ca5b6..15d382f6f9f8 100644
--- a/drivers/clk/imx/clk-scu.c
+++ b/drivers/clk/imx/clk-scu.c
@@ -8,6 +8,7 @@
 #include <linux/arm-smccc.h>
 #include <linux/clk-provider.h>
 #include <linux/err.h>
+#include <linux/module.h>
 #include <linux/of_platform.h>
 #include <linux/platform_device.h>
 #include <linux/pm_domain.h>


--==_Exmh_1604318525_168427P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBX5/1PAdmEQWDXROgAQIOzQ/9Fh7u7CjJVVvYfQl56BjwcIOwsPn57c65
vQ6RAXnr84O89rd4vWtCP2WVmiWXp7kvsYOrB5LJtGCdhTMoeh80pcJmpJUo2y0G
6MLBdcPoXIUbbPt57pjA77EzV/KydYT1FUeZuiyZrdFCuG1yBpSz6J8tZ9nokFzY
Nv9QHT7H6HVS+y4FtCOmL3ivdsQrSHBBQ7MX9A7AsMrNymfOTvkmeIDK9NJk2E87
uAtIpuSM3WwEl1/ImYlAscXnEBeHuN3Eo+C0iqDp4fVCcb+qFXgdUEr32cTlROmh
HhzENBi1AAIyZnudkPcpbViJyUmEXtklvJYjckQKVHhcI5ewj7whG/x1H+hDkZ+r
hJRxFHp0iLvaIwDqhDDhqz6Yzonk898l+RyhXd0XLpu+9XytrpUnbH+GkslvY8yo
qmeQXvYcDK+B07CvIavfwr92woS+0w7c8JUT66Z9g7obDLlsxkUOw4NsBmple/Nq
WziGk8FcWJA9QwHC0NFyMGIMQ2DmXyN1gZ001R3F4GoJF4SzhcV9FmF1lI5qiCkd
FEQu3//fbNeSVMJQCEjTaXGciglNVSv4SzIChCjPZ6GFhC69ILAqc5TeGWVq8K9G
JhxrvUmz79K6NYh6fp1ijsjN4JnHmYZsbl0Sw+IcYMfzywFbU0tQ7BmOS4eI/kd1
I/f+VaDSDO8=
=LaUB
-----END PGP SIGNATURE-----

--==_Exmh_1604318525_168427P--