Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3303135pxx; Mon, 2 Nov 2020 05:36:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJw99X4xJecNH7GRCzT/au8GhPQxqa7ZjpjXbtkbsvJefEzOpWlqK6y8xgzUvV91Vko6z7ox X-Received: by 2002:a50:fe14:: with SMTP id f20mr10182034edt.61.1604324189844; Mon, 02 Nov 2020 05:36:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604324189; cv=none; d=google.com; s=arc-20160816; b=oOA2HfWftlNEzdzthTMa+3ym/jDg/+ds8G/AZ1G14TYJw1CGy9sUWSSdRHy3TKM1Ub 9ebxrZ0niLZjtFmWLLtGjUHG0VXzAwnlRkUU9dlzyPCfIPW/u6LOloiYlhuBgInmIO6N 3SivuMv8CmCNZkYrc0uFV1sxOiFn+g4UO0+LBQLv5AQxfcYXBhi4dysGCODn90/gH91Q e+lu/0CJmEoqhpomiKYJ06HfUIBQM77kbTYW4AsLTsPp4Lm0v9dZnIpTNJZODQ7qrEQj lTyKeLoOCSAQQFRZrBWUikf7C/1NuJQTFk3f0mahUlxf8gLmK296CkQ+HeuyXfGmYdox tYkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=i9gESZahS8bfitkJKc3X0BxnqhvZMTaj3/oDR+AqY3M=; b=yaOohme2CVB1VYAV3xEDQKIIWtx5y6rbAj5GR9cMvdUNXTPW0yEi9HntPeZatOzqYS +J+i0lZE+CLeTnm9srU7BEU17xWy3wTryrE81A8bC6v4j/bNLXQ3WAdfsPTHDba5Mb5g /iHqdc6BA5SXRBh1VoJqHzERJq3eVqtPQ3PUUKn0X14iQLbKBS91DTDF9nlNnrEOcd6Y F8Mp/zjLlNpedGCuuWv31L8xPlr+NPDJPUjdBZCO6WNPFBlNgqipSICbGo99VI3CxbZ+ i2aqaGcG4XmWsN7y1baIekLcYjomkcCMbHheDBgPdlsvbriaS3JopD00xIXMDHYnbxNu HIGg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r26si14785364edc.350.2020.11.02.05.36.06; Mon, 02 Nov 2020 05:36:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725914AbgKBNeQ (ORCPT + 99 others); Mon, 2 Nov 2020 08:34:16 -0500 Received: from vps0.lunn.ch ([185.16.172.187]:58518 "EHLO vps0.lunn.ch" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbgKBNeP (ORCPT ); Mon, 2 Nov 2020 08:34:15 -0500 Received: from andrew by vps0.lunn.ch with local (Exim 4.94) (envelope-from ) id 1kZZyK-004ou3-Hj; Mon, 02 Nov 2020 14:34:08 +0100 Date: Mon, 2 Nov 2020 14:34:08 +0100 From: Andrew Lunn To: Pavana Sharma Cc: marek.behun@nic.cz, ashkan.boldaji@digi.com, davem@davemloft.net, f.fainelli@gmail.com, gregkh@linuxfoundation.org, kuba@kernel.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, vivien.didelot@gmail.com Subject: Re: [PATCH v7 3/4] net: dsa: mv88e6xxx: Change serdes lane parameter from u8 type to int Message-ID: <20201102133408.GG1109407@lunn.ch> References: <205569de82d73e543625583e55e808981a7c9ee8.1604298276.git.pavana.sharma@digi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <205569de82d73e543625583e55e808981a7c9ee8.1604298276.git.pavana.sharma@digi.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > @@ -985,12 +985,12 @@ int mv88e6390_serdes_get_regs_len(struct mv88e6xxx_chip *chip, int port) > void mv88e6390_serdes_get_regs(struct mv88e6xxx_chip *chip, int port, void *_p) > { > u16 *p = _p; > - int lane; > + int lane = -ENODEV; > u16 reg; > int i; The reverse christmas tree is wrong here. Andrew