Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Vladimir Oltean <vladimir.oltean@nxp.com>
To:     Pujin Shi <shipujin.t@gmail.com>
CC:     Jakub Kicinski <kuba@kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: mscc: fix missing brace warning for old
 compilers
Thread-Topic: [PATCH] net: ethernet: mscc: fix missing brace warning for old
 compilers
Thread-Index: AQHWsR3tdRvpxbUwu0avLaQhXZnXo6m03c4A
Date:   Mon, 2 Nov 2020 13:56:55 +0000
Message-ID: <20201102135654.gs2fa7q2y3i3sc5k@skbuf>
References: <20201102134136.2565-1-shipujin.t@gmail.com>
In-Reply-To: <20201102134136.2565-1-shipujin.t@gmail.com>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <8044285B2D066D48AD6D2C367E0A8550@eurprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: de83583e-e492-4150-8339-08d87f37287d
X-MS-Exchange-CrossTenant-originalarrivaltime: 02 Nov 2020 13:56:55.1348
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: s6xURzdMFavawxoN5ZQrcknQ3v4sP7/5nG/KH1k/6W2bHkkPXfMZB8XMBRrsclO7uoM4UViSSU1PSRtCFYHqLA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB5134
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Mon, Nov 02, 2020 at 09:41:36PM +0800, Pujin Shi wrote:
> For older versions of gcc, the array =3D {0}; will cause warnings:
>=20
> drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set':
> drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: missing braces a=
round initializer [-Wmissing-braces]
>     struct ocelot_vcap_u16 etype =3D {0};
>            ^
> drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: (near initializa=
tion for 'etype.value') [-Wmissing-braces]
>=20
> 1 warnings generated
>=20
> Fixes: 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan=
 actions to VCAP IS1")
> Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
> ---
>  drivers/net/ethernet/mscc/ocelot_vcap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.c b/drivers/net/ethern=
et/mscc/ocelot_vcap.c
> index d8c778ee6f1b..b96eab4583e7 100644
> --- a/drivers/net/ethernet/mscc/ocelot_vcap.c
> +++ b/drivers/net/ethernet/mscc/ocelot_vcap.c
> @@ -752,7 +752,7 @@ static void is1_entry_set(struct ocelot *ocelot, int =
ix,
>  					     dport);
>  		} else {
>  			/* IPv4 "other" frame */
> -			struct ocelot_vcap_u16 etype =3D {0};
> +			struct ocelot_vcap_u16 etype =3D {};
> =20
>  			/* Overloaded field */
>  			etype.value[0] =3D proto.value[0];
> --=20
> 2.18.1
>=20

Sorry, I don't understand what the problem is, or why your patch fixes
it. What version of gcc are you testing with?=