Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S964821AbWHQLnh (ORCPT ); Thu, 17 Aug 2006 07:43:37 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964824AbWHQLnh (ORCPT ); Thu, 17 Aug 2006 07:43:37 -0400 Received: from mailhub.sw.ru ([195.214.233.200]:59565 "EHLO relay.sw.ru") by vger.kernel.org with ESMTP id S964821AbWHQLng (ORCPT ); Thu, 17 Aug 2006 07:43:36 -0400 Message-ID: <44E456F4.10001@sw.ru> Date: Thu, 17 Aug 2006 15:45:56 +0400 From: Kirill Korotaev User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.13) Gecko/20060417 X-Accept-Language: en-us, en, ru MIME-Version: 1.0 To: Greg KH CC: Andrew Morton , Linux Kernel Mailing List , Alan Cox , Ingo Molnar , Christoph Hellwig , Pavel Emelianov , Andrey Savochkin , devel@openvz.org, Rik van Riel , hugh@veritas.com, ckrm-tech@lists.sourceforge.net, Andi Kleen Subject: Re: [RFC][PATCH 2/7] UBC: core (structures, API) References: <44E33893.6020700@sw.ru> <44E33BB6.3050504@sw.ru> <20060816171527.GB27898@kroah.com> In-Reply-To: <20060816171527.GB27898@kroah.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 581 Lines: 19 >>+struct user_beancounter >>+{ >>+ atomic_t ub_refcount; > > > Why not use a struct kref here instead of rolling your own reference > counting logic? We need more complex decrement/locking scheme than krefs provide. e.g. in __put_beancounter() we need atomic_dec_and_lock_irqsave() semantics for performance optimizations. Kirill - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/