Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 2 Nov 2020 15:27:44 +0100
From:   Maxime Ripard <maxime@cerno.tech>
To:     Paul Kocialkowski <contact@paulk.fr>
Cc:     devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org, Rob Herring <robh+dt@kernel.org>,
        Chen-Yu Tsai <wens@csie.org>,
        Matteo Scordino <matteo.scordino@gmail.com>,
        Icenowy Zheng <icenowy@aosc.io>
Subject: Re: [PATCH 8/9] dt-bindings: arm: sunxi: Add SL631 with IMX179
 bindings
Message-ID: <20201102142744.lxjvu67pr7dmxzo7@gilmour.lan>
References: <20201031182137.1879521-1-contact@paulk.fr>
 <20201031182137.1879521-9-contact@paulk.fr>
 <20201102101333.4bm2lfqpqnbpyp63@gilmour.lan>
 <20201102103340.GD11809@aptenodytes>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
        protocol="application/pgp-signature"; boundary="cdmzcvhmv6crmjoh"
Content-Disposition: inline
In-Reply-To: <20201102103340.GD11809@aptenodytes>
Precedence: bulk


--cdmzcvhmv6crmjoh
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Mon, Nov 02, 2020 at 11:33:40AM +0100, Paul Kocialkowski wrote:
> Hi,
>=20
> On Mon 02 Nov 20, 11:13, Maxime Ripard wrote:
> > On Sat, Oct 31, 2020 at 07:21:36PM +0100, Paul Kocialkowski wrote:
> > > Document the compatible strings for the SL631 Action Camera with IMX1=
79.
> > >=20
> > > Signed-off-by: Paul Kocialkowski <contact@paulk.fr>
> > > ---
> > >  Documentation/devicetree/bindings/arm/sunxi.yaml | 6 ++++++
> > >  1 file changed, 6 insertions(+)
> > >=20
> > > diff --git a/Documentation/devicetree/bindings/arm/sunxi.yaml b/Docum=
entation/devicetree/bindings/arm/sunxi.yaml
> > > index afa00268c7db..0fa0c0b5d89f 100644
> > > --- a/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > +++ b/Documentation/devicetree/bindings/arm/sunxi.yaml
> > > @@ -754,6 +754,12 @@ properties:
> > >            - const: sinlinx,sina33
> > >            - const: allwinner,sun8i-a33
> > > =20
> > > +      - description: SL631 Action Camera with IMX179
> > > +        items:
> > > +          - const: unknown,sl631-imx179
> > > +          - const: unknown,sl631
> > > +          - const: allwinner,sun8i-v3
> > > +
> >=20
> > unknown is not a valid vendor (and you should explain why you picked
> > that vendor name in the first place).
>=20
> Ah right, it's not in the vendor prefixes. The rationale is that there is=
 no
> indication of what the vendor might be on the PCB. Should I maybe use
> allwinner here?

You should mention it in the commit log for a start :)

But yeah, we've used allwinner as a fallback for those cases so far.

Maxime

--cdmzcvhmv6crmjoh
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCX6AXYAAKCRDj7w1vZxhR
xazfAQCTALPCW+BoUtOYsJJCGdpXhyQe4JgWh6/BgXFj86SV9QD/Rmpkyj/D2Z9u
FkBRpMa2xPFAKK2SudAbNcYpnU9mcAg=
=k95c
-----END PGP SIGNATURE-----

--cdmzcvhmv6crmjoh--