Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3353203pxx; Mon, 2 Nov 2020 06:49:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJyAPfKNSdNTRf6cCAnX5ID9rk/cLjrIQ6JziPxX0lqeR76Rmr8ouKi9VOug2eD+YwdhLc5y X-Received: by 2002:aa7:cdd9:: with SMTP id h25mr10189477edw.294.1604328570301; Mon, 02 Nov 2020 06:49:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604328570; cv=none; d=google.com; s=arc-20160816; b=YAyZpHdRL7JVDvlM8EwTUMFPhAyWuCmdK7UHfh320vkP5rHPmeyMCZ6749oA0Imx9o IlfsD26xS7TYXL8hxRzv8TNjajEcQBwyrThFQ9WAjYC162Crs2LROxO2pgGayl70op52 yPMLxe5EfRM4ulAX4vA9KhejwXtcHUV/8WxSzmhRZsJSaC1Xz4b960kMG3vdE1UCIHn4 pnmARux/CUv1nDjG7Y5V91aYI29bVnZnmnUceKbpUIq68OaxUhRhcbfQ0FEpGMTIPM0I Co3E38sr4QITY5HafrHELwECptTeXO25AJn0CYW6ramOHgTsg1IMDramiFa6N4NouMcQ VZBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=2EQEYsdl91ythedVS5CbIaac/O1VzM4oNTqK3zX2+mk=; b=s80Vsu473UIuj/qULPNYC7l37ZXel7ggjt72jcYzduQhlIRx2BQlmcachD1aVuZSn6 g9pqjQf3iq7YA9WmYYkoMGtsjHGFpxqFSxUlFnS9iEAyok0WTP+wDgTpe2WrVQ9bnCrX +G8aYbtstCHJNzkiB/GTxCJf84DXQkREQw8h19XttERQnUVRYGAuEXB0QQ/AYaE/gL2Y kHXpxJw30sf2v1mklSWwkTWaTR7x5VUIa1sRIyZ4t55zyMbmZOmeSpKsvwJjphi/pLOO J3rDwgVbQw1dLPtk75/sEw/BdUriwtLjfkULOf4AIHBRDXomirTNaafh60LcKtfCHFUE tIvQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=XBPlkqmR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 94si3514075edq.570.2020.11.02.06.49.06; Mon, 02 Nov 2020 06:49:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@cmpxchg-org.20150623.gappssmtp.com header.s=20150623 header.b=XBPlkqmR; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=cmpxchg.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725983AbgKBOro (ORCPT + 99 others); Mon, 2 Nov 2020 09:47:44 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51538 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbgKBOrn (ORCPT ); Mon, 2 Nov 2020 09:47:43 -0500 Received: from mail-qk1-x741.google.com (mail-qk1-x741.google.com [IPv6:2607:f8b0:4864:20::741]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 53837C061A04 for ; Mon, 2 Nov 2020 06:47:43 -0800 (PST) Received: by mail-qk1-x741.google.com with SMTP id x20so11658384qkn.1 for ; Mon, 02 Nov 2020 06:47:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=2EQEYsdl91ythedVS5CbIaac/O1VzM4oNTqK3zX2+mk=; b=XBPlkqmRr/I9IXZ93ewuFmXOVmiqScb7IKEEpyKP6hDEFveEL+2iyaWz2Rap78rQsv PhSuMRS+tMZrnEoCMtNlZCNPr/b8PcyBKL+rNSFR3VUw/vyM03pEOTBYs6io9c6W/+5V m+Yi9eLNS9TUDzPEVQhdtb5ey/6XoJUzJcdDErfRkkXJvIiSRGqsxEuJk9liWJNGQFDK X3/YKbeCkUS27pVkmCABhGYexhEMFN/wZAFRUhCRJjL4vH691liVm8mXQIKVywQUaney EkUScfWC0PqqjKvxYeTLKUz+ZuSOmqiwzWwymxMFkP+sz/oEs63OX32bcp6ytc90vdO2 gGuQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=2EQEYsdl91ythedVS5CbIaac/O1VzM4oNTqK3zX2+mk=; b=mMhqU7LvIxucDed8kd6Sz2tEJ7eORVHzahFqol1XGFl0Uf6wXF7+GGCBWjdFfp+Khl I1kIpZdy7rJ3/OJUlJHulpLXLpDjsC0Ot/+DSv31W4ySpHN2aVk+5MzpRuh2RYYvWH0F axBv8LOXcRNKXgMBL9z+veGeKpm1Jbvg+rRYvTAL3OBy/Bjapkg2olOxceDO4dm6EWJS mLqTOu9AASiwhW9a2KAaI4b7WOR+h1izFO5/k9rXlSdR18qF1r1hkYclMCaq8n2ehAAI jVogQg8OYs9E3uB5HlpF26Ny6A6c/o1ZpRdQpE3pKKJf4QKyI/EOqoxN8i/BlqukUHeo /tjw== X-Gm-Message-State: AOAM5313Bq7bONM4R3GyFNpSphhN+1rstXjdU7fPaxC/8rAaAJRwBvtt 7Wojbu+fB2jqNDpgePUQy+g74g== X-Received: by 2002:a05:620a:21c4:: with SMTP id h4mr13587374qka.242.1604328462641; Mon, 02 Nov 2020 06:47:42 -0800 (PST) Received: from localhost ([2620:10d:c091:480::1:2f6e]) by smtp.gmail.com with ESMTPSA id 66sm5935254qkd.81.2020.11.02.06.47.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 06:47:41 -0800 (PST) Date: Mon, 2 Nov 2020 09:45:57 -0500 From: Johannes Weiner To: Alex Shi Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Michal Hocko Subject: Re: [PATCH v20 09/20] mm/memcg: add debug checking in lock_page_memcg Message-ID: <20201102144557.GC724984@cmpxchg.org> References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-10-git-send-email-alex.shi@linux.alibaba.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1603968305-8026-10-git-send-email-alex.shi@linux.alibaba.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Oct 29, 2020 at 06:44:54PM +0800, Alex Shi wrote: > Add a debug checking in lock_page_memcg, then we could get alarm > if anything wrong here. > > Suggested-by: Johannes Weiner > Signed-off-by: Alex Shi > Acked-by: Hugh Dickins > Cc: Johannes Weiner > Cc: Michal Hocko > Cc: Vladimir Davydov > Cc: Andrew Morton > Cc: cgroups@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: linux-kernel@vger.kernel.org Acked-by: Johannes Weiner