Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3371827pxx; Mon, 2 Nov 2020 07:14:46 -0800 (PST) X-Google-Smtp-Source: ABdhPJzOEhN0L8LDVM+8iwezelCdDOvxhedeeFlvUCykW5q+G87tBjVJWPcPbXhPkUjlDOw3DBKT X-Received: by 2002:a17:906:d9dd:: with SMTP id qk29mr6469614ejb.487.1604330085860; Mon, 02 Nov 2020 07:14:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604330085; cv=none; d=google.com; s=arc-20160816; b=Rfzd/d0md/MQMNuQ1r8Hx7dyO9JJ5ipfZ00EiZ9R6ZqXLOmbPdwsRoWhjlOGEoKYve jYhrMOHf516WrEKaIOPeXxbanQUAW6Skkd7crDDvJjt+FBGTTZVR74vQ2/HcN0cHxmQv 4W6PzDx8BwKQ1x7dBpdC/cz/VP0KxWLf1qLiZIyXNKWVgfl5tIf406rHIROc1lD1dix9 QjagKi+9Ono7c6eMUOalGJ0ePZrDSbB2v5j0Xo8EWjCgQITfcyPgnEjQ40bE8HZXjI85 VXB37Rp/ICmV3ZweI2fj+6rsjQyS5ksG2HKiACHBWZZ8A6Ij4eaJ8H/DlepsNHe/DrgB yjLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:dkim-signature:mime-version:references :in-reply-to:message-id:date:subject:cc:to:from; bh=FxtLB3V25/9092fJImUbmEK5DDd1xaC11DWTieE2aCs=; b=chS8LPE6WPtWJ7zVYOTgvk7PusFkZCMeas1zK44668j9K3RIT0btNlNSb0gAb86oPC LkCfwrbo4L0yI+drHFNSWPkF2utkGiBPUFsMJKwuogK5pENmuky2oBkDLLYl9wNsNyBm AQEFhhvn0lbHAxM4gbe+ddPGN4dpObTDBBFvGWTf4a/DjXNjiJ+d5r8zsyvuIkZ0z/L0 NQyhzjHnkAz4D4VPLCrqilhesREZu0bk/WoXaQIiOE/MEwkqdcM6zH4F50FGAu51hCfl QhebWxUhiRhZ7wzJpAh6piZi0WRXaDMd/hlT4JOi+CoE0kVZm8z2LN32AljtSSjcqoup 01oA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=J0TiS14y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id f16si13681072edy.384.2020.11.02.07.14.23; Mon, 02 Nov 2020 07:14:45 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@nvidia.com header.s=n1 header.b=J0TiS14y; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=nvidia.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726140AbgKBPLh (ORCPT + 99 others); Mon, 2 Nov 2020 10:11:37 -0500 Received: from hqnvemgate25.nvidia.com ([216.228.121.64]:4746 "EHLO hqnvemgate25.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726211AbgKBPLg (ORCPT ); Mon, 2 Nov 2020 10:11:36 -0500 Received: from hqmail.nvidia.com (Not Verified[216.228.121.13]) by hqnvemgate25.nvidia.com (using TLS: TLSv1.2, AES256-SHA) id ; Mon, 02 Nov 2020 07:11:36 -0800 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL111.nvidia.com (172.20.187.18) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Mon, 2 Nov 2020 15:11:32 +0000 Received: from audio.nvidia.com (10.124.1.5) by mail.nvidia.com (172.20.187.12) with Microsoft SMTP Server id 15.0.1473.3 via Frontend Transport; Mon, 2 Nov 2020 15:11:29 +0000 From: Sameer Pujar To: , , , , , CC: , , , , , , Sameer Pujar Subject: [PATCH v5 4/7] ASoC: audio-graph: Identify 'no_pcm' DAI links for DPCM Date: Mon, 2 Nov 2020 20:40:11 +0530 Message-ID: <1604329814-24779-5-git-send-email-spujar@nvidia.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1604329814-24779-1-git-send-email-spujar@nvidia.com> References: <1604329814-24779-1-git-send-email-spujar@nvidia.com> MIME-Version: 1.0 Content-Type: text/plain DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1604329896; bh=FxtLB3V25/9092fJImUbmEK5DDd1xaC11DWTieE2aCs=; h=From:To:CC:Subject:Date:Message-ID:X-Mailer:In-Reply-To: References:MIME-Version:Content-Type; b=J0TiS14ySJ6VSZiUMAQ9K6ym9L4kBsHIijkaX1DZS1kYNd+YbASCFvEb5IjhwFjqG dpMBwG11IkBmE0ugtirafAzSZjy92+Mx3niF9UV5NMqwztRfFOQC4eQB+elJW6c0rC he8FP1PQAIfaeJz4YOylx6YN1UQklxT6eLmcJW9+e0pj9Ra3BVHAaMBadPHSajZspq hFU2Rzds2KbqdfA6lpW2HyB24e1kVzU0P5yoAlyY86kvXBjpiGu8WeVIazaUFraYNn KpE1aTCMZxkXjur/g8NLERhyD5vofY0lI1o7dYWzWf1UHCq2hnolnEBDtf3+A/vXCo vE9sDTUUKxDsA== Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org PCM devices are created for FE dai links with 'no-pcm' flag as '0'. Such DAI links have CPU component which implement either pcm_construct() or pcm_new() at component or dai level respectively. Based on this, current patch exposes a helper function to identify such components and populate 'no_pcm' flag for DPCM DAI link. This helps to have BE<->BE component links where PCM devices need not be created for CPU component involved in such links. Signed-off-by: Sameer Pujar Cc: Kuninori Morimoto --- sound/soc/generic/audio-graph-card.c | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/sound/soc/generic/audio-graph-card.c b/sound/soc/generic/audio-graph-card.c index 1e20562..9b06841 100644 --- a/sound/soc/generic/audio-graph-card.c +++ b/sound/soc/generic/audio-graph-card.c @@ -111,6 +111,17 @@ static int graph_get_dai_id(struct device_node *ep) return id; } +static bool soc_component_is_pcm(struct snd_soc_dai_link_component *dlc) +{ + struct snd_soc_dai *dai = snd_soc_find_dai_with_mutex(dlc); + + if (dai && (dai->component->driver->pcm_construct || + dai->driver->pcm_new)) + return true; + + return false; +} + static int asoc_simple_parse_dai(struct device_node *ep, struct snd_soc_dai_link_component *dlc, int *is_single_link) @@ -205,6 +216,7 @@ static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv, int dup_codec) { struct device *dev = simple_priv_to_dev(priv); + struct snd_soc_card *card = simple_priv_to_card(priv); struct snd_soc_dai_link *dai_link = simple_priv_to_link(priv, li->link); struct simple_dai_props *dai_props = simple_priv_to_props(priv, li->link); struct device_node *top = dev->of_node; @@ -259,6 +271,19 @@ static int graph_dai_link_of_dpcm(struct asoc_simple_priv *priv, if (ret < 0) goto out_put_node; + /* + * In BE<->BE connections it is not required to create + * PCM devices at CPU end of the dai link and thus 'no_pcm' + * flag needs to be set. It is useful when there are many + * BE components and some of these have to be connected to + * form a valid audio path. + * + * For example: FE <-> BE1 <-> BE2 <-> ... <-> BEn where + * there are 'n' BE components in the path. + */ + if (card->component_chaining && !soc_component_is_pcm(cpus)) + dai_link->no_pcm = 1; + /* card->num_links includes Codec */ asoc_simple_canonicalize_cpu(dai_link, is_single_links); } else { -- 2.7.4