Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3391219pxx; Mon, 2 Nov 2020 07:43:28 -0800 (PST) X-Google-Smtp-Source: ABdhPJzzJGfd61M9UgXPHF4dI2Zim2kv2n0sCY9FfVmxYddhKMDlU2G6eusILBpxFhJxqC5+69xN X-Received: by 2002:a17:906:b043:: with SMTP id bj3mr15595790ejb.543.1604331807863; Mon, 02 Nov 2020 07:43:27 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604331807; cv=none; d=google.com; s=arc-20160816; b=i2DxT91camujjRFOeGb95mdbaTqullT7fJ0njCX9CdhO5X6DDE1Da681v4OSzj4MLT ZYnRvl9Lqq/vOiyze37tFVih/rLgg9x+VQVTZ10CXIXhj1DGJ1TnWZl5lCG1J1+OVK0U TqcvUbkcsL4ruQNCibqLgnTQG2BE64VBnNGzSZHZpemORo+ErnHF4dHJMvgRYlOS84uy gqYlAjHEVrryVTfSHnWyhM87+tqT2DZTTmbHTqHVltFCI6v2mUHyF2Og8CJUppbT15DT LmwiWO45gbWuA0CrdGVlbBvBjbWVg8CgWA5l2GAXhQVH+oyobvq97yT72r5+PETe21Jy nlAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:in-reply-to:content-disposition:mime-version :references:message-id:subject:cc:to:from:date:dkim-signature; bh=UmWNoo+0jio1rsbpATbpnTKOP6YpDT2+8aHnhsn1BNQ=; b=Qq6X6ixrDHgbwxZYlh81UxaPWOyacEb2kAhSQB7zVyYzQbaMIiFn6UbVoq4ktHovib OUvay5UIYa/49AmoL6/hBb4wMaZh/zONHjmSsPzYTfBE0tGfe27PGuwxZubuq8dUoTmc 8HrQ6rfTGTpfO5bnjSV1S2L56P1H4+Ml77qMMCILHsAHsNQTFl3KnCbyTqjkDcuo4kNc eCUwFob4oyS8PPZ5vdmMPkgiJ9E+FJB0pSx1D7sU3ELCHnFlUNZN7za1NBwWQFPkh983 psfrvKm7V5IcV8d6hcgo7pFCEG3VQap/O3keYg4Ru7GIS7vhEgUgS+QWDRSLsWzFeIMa 7SCw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=cf1MSWB7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id cc10si6342213edb.156.2020.11.02.07.43.02; Mon, 02 Nov 2020 07:43:27 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@infradead.org header.s=casper.20170209 header.b=cf1MSWB7; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726581AbgKBPli (ORCPT + 99 others); Mon, 2 Nov 2020 10:41:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725791AbgKBPlh (ORCPT ); Mon, 2 Nov 2020 10:41:37 -0500 Received: from casper.infradead.org (casper.infradead.org [IPv6:2001:8b0:10b:1236::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 98B58C0617A6; Mon, 2 Nov 2020 07:41:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=UmWNoo+0jio1rsbpATbpnTKOP6YpDT2+8aHnhsn1BNQ=; b=cf1MSWB7BC+d/XGfBcQ2kzWTKP Peh8sMqwcaL1avawa0skij5vzCJuMhLjyf5+3duC9LV64xK5h7mYlExaCNl16g5xIgy0XYatg9Kkf 8MzQdAQ7nqnViyK6PC8RcELKGC+j9GZJ7ckJm169iVg6QlV5ggKqdv+lcQqqbrPMl+FlSrL0fJtVH h3aIS4VO2YSOq9iZcZt7+s5WtKwHYRjz80MESyljeOHnTABAzm0KwnO67EhkQGqAYQ3ow0H2PyBl3 OZ6Wcz1eC4cFYhDOYdlGwsV1WdJGKy68/ZW9RvzSJwxRicr1Ax69ZJI0224mH0dP7B11Lada3H09n ylAgZRSA==; Received: from willy by casper.infradead.org with local (Exim 4.92.3 #3 (Red Hat Linux)) id 1kZbx7-0002Pe-5d; Mon, 02 Nov 2020 15:41:01 +0000 Date: Mon, 2 Nov 2020 15:41:01 +0000 From: Matthew Wilcox To: Bartosz Golaszewski Cc: Andy Shevchenko , Sumit Semwal , Gustavo Padovan , Christian =?iso-8859-1?Q?K=F6nig?= , Mauro Carvalho Chehab , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alexander Shishkin , Linus Walleij , "Michael S . Tsirkin" , Jason Wang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Jaroslav Kysela , Takashi Iwai , linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, linux-kernel@vger.kernel.org, linux-edac@vger.kernel.org, linux-gpio@vger.kernel.org, kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev@vger.kernel.org, linux-mm@kvack.org, alsa-devel@alsa-project.org, Bartosz Golaszewski , Vlastimil Babka Subject: Re: [PATCH v2 1/8] mm: slab: provide krealloc_array() Message-ID: <20201102154101.GO27442@casper.infradead.org> References: <20201102152037.963-1-brgl@bgdev.pl> <20201102152037.963-2-brgl@bgdev.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201102152037.963-2-brgl@bgdev.pl> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 02, 2020 at 04:20:30PM +0100, Bartosz Golaszewski wrote: > +Chunks allocated with `kmalloc` can be resized with `krealloc`. Similarly > +to `kmalloc_array`: a helper for resising arrays is provided in the form of > +`krealloc_array`. Is there any reason you chose to `do_this` instead of do_this()? The automarkup script turns do_this() into a nice link to the documentation which you're adding below. Typo 'resising' resizing.