Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3392527pxx; Mon, 2 Nov 2020 07:45:26 -0800 (PST) X-Google-Smtp-Source: ABdhPJwRxF8RYfmPSj+izR3NItDqFSQsOkWM6R7OV/7+u9UkffxdtSGrANZk42jXbXUbX4VVaKYQ X-Received: by 2002:aa7:de97:: with SMTP id j23mr17352753edv.45.1604331926603; Mon, 02 Nov 2020 07:45:26 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604331926; cv=none; d=google.com; s=arc-20160816; b=C5co6K1oO2hZVlN7De/H1js30Miiuyy6w01qAD6H8by+GDZz6sZ2zprunJJ5bJagwL 0RaCCQ+pVMJU+4LB+qdjgvUPHpE3nRQhsa5pnjukxJTURPQclPwiqdJOQD1QUmi612s2 a4VAd/Y/j5UKpB2bO0nfOfwgpMi/BcV/T1Ym1iPWC41OIaIP4CL1C8UVguPEWyZNKHR0 ZEdDikIYgiRdVIQezMQv7777Bnt4m5pZovUmH/HPMHAgmpryeu8OmnNA7xlZFCh5IOi8 5raTSr3T3MmR8ATyB7hTjrYXoUqC2oF3c+IvlTjTcNoeLWWbw6AcM+Gf7x1dvRatJ8Yz Y0qQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:cc:to:subject:message-id:date:from:in-reply-to :references:mime-version:dkim-signature; bh=nS8GcWnRvgAze9eGONKgTm54dvXOecWjyagLlZce7Is=; b=oujfq5y2GUWkB0+xJGcR0zHBJFzVVq001gcn+ITi4SMsOylYPCDCGkcq0VNDEO8ETf SAkuUoKwTEMXFeMyocUnheaJ8Zv1o8OaMuxI3TZCm+/WzNz/8FNbRdqRVRS7/P1JX9Rk KlZTKzuEOhsK8VI06vpI1Clvw6wIQntfmpkcQp88neqZWZKPeLedlrcQI5jXAY5mTwzL OTIl1VrFYGAscFZBzCxjhSvj1UHvdnAIwrJ6GmhiYLsxMDj1dq68BPmHyzmnsI23j7iV HSp/wvskS9g6ONYV60RGS+jyQpSNzYdQNSJ/CBN3xBJQI7hTyzf7ZEbhn3E1YHLsQD95 O9OA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=GeZOTcEL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r16si10130852ejs.21.2020.11.02.07.45.02; Mon, 02 Nov 2020 07:45:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@baylibre-com.20150623.gappssmtp.com header.s=20150623 header.b=GeZOTcEL; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726613AbgKBPng (ORCPT + 99 others); Mon, 2 Nov 2020 10:43:36 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60392 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726540AbgKBPnf (ORCPT ); Mon, 2 Nov 2020 10:43:35 -0500 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 63C7CC061A48 for ; Mon, 2 Nov 2020 07:43:35 -0800 (PST) Received: by mail-ej1-x642.google.com with SMTP id oq3so17637142ejb.7 for ; Mon, 02 Nov 2020 07:43:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=nS8GcWnRvgAze9eGONKgTm54dvXOecWjyagLlZce7Is=; b=GeZOTcELL0wHCC2LsYMp4AHDK/U4F0TpiMBx0TLSL9ySl4L4C8XcHcbUz5fZNLjniM TuvyR4acGxkL9PjF4zrWBiY258C6IcsF0J9LR6SowCpPKmCKno9m8GSu4pQU9/WnDZH7 7UkFNkQaU4R7nVWteNdPvBIJxPPgU8WHblr0zM6zQdwUqyKaEmqLaDFu3SLFEdkz8070 +tw2ItP8FRhBWa/R+2tqWgkisP8VzJCQvEhMDs6cgObDq+FQOIe0RTsRoPUGJizua2af DerEr/5gFY6bKe9hU6ejx4bsKfOsV8bd9SlGakYbkn/eCz8qeemmHfgRz2JwvgXFT4AO tsEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=nS8GcWnRvgAze9eGONKgTm54dvXOecWjyagLlZce7Is=; b=KGk5TYjheNngCHFVWWjDTebhc1OJiyuHwaTVQiarFb1f8zZUmj3z3kDuqB/CnyN674 g3gAZj6K3PSXFwJtVkWZJgaDF5uj16wntXFYo7WN/mFZ7mDZs00yLFF76bR4LRrxuMFW R00NyFUwHNhMBKxMjyY1pL1O3c1qsSMOMMTvqyXoeJgsgNOw8DwIdLLSDwn4+HkyT1za kX8or4b0l48X6MJWdSPrxN3mYoYWiMw4TPSg4d6aXB5wzg5FOf6U6FaawAj93FmKVKCs lsM9YgOYZBt4D3zonqi1J+Ls3MJz1gawYpxY/yjEA9gZoYmJm2rH4JntbPyK0LIsa99y DXWA== X-Gm-Message-State: AOAM530hQqMKsWzHcUho4caDcyID0UCO2DZgYLHknuoifoum8ZStn0U5 PVCx5Pm9lLsPi5gSWf7f5lTtqHkf0x2LzgZ5Vv4EmA== X-Received: by 2002:a17:906:1c84:: with SMTP id g4mr2189231ejh.155.1604331814011; Mon, 02 Nov 2020 07:43:34 -0800 (PST) MIME-Version: 1.0 References: <20201102152037.963-1-brgl@bgdev.pl> <20201102152037.963-2-brgl@bgdev.pl> <20201102154101.GO27442@casper.infradead.org> In-Reply-To: <20201102154101.GO27442@casper.infradead.org> From: Bartosz Golaszewski Date: Mon, 2 Nov 2020 16:43:22 +0100 Message-ID: Subject: Re: [PATCH v2 1/8] mm: slab: provide krealloc_array() To: Matthew Wilcox Cc: Bartosz Golaszewski , Andy Shevchenko , Sumit Semwal , Gustavo Padovan , =?UTF-8?Q?Christian_K=C3=B6nig?= , Mauro Carvalho Chehab , Borislav Petkov , Tony Luck , James Morse , Robert Richter , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Daniel Vetter , Alexander Shishkin , Linus Walleij , "Michael S . Tsirkin" , Jason Wang , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Andrew Morton , Jaroslav Kysela , Takashi Iwai , linux-media , linux-drm , linaro-mm-sig@lists.linaro.org, LKML , linux-edac@vger.kernel.org, linux-gpio , kvm@vger.kernel.org, virtualization@lists.linux-foundation.org, netdev , linux-mm@kvack.org, Linux-ALSA , Vlastimil Babka Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Nov 2, 2020 at 4:41 PM Matthew Wilcox wrote: > > On Mon, Nov 02, 2020 at 04:20:30PM +0100, Bartosz Golaszewski wrote: > > +Chunks allocated with `kmalloc` can be resized with `krealloc`. Similarly > > +to `kmalloc_array`: a helper for resising arrays is provided in the form of > > +`krealloc_array`. > > Is there any reason you chose to `do_this` instead of do_this()? The > automarkup script turns do_this() into a nice link to the documentation > which you're adding below. > No, I just didn't know better. Thanks for bringing this to my attention. > Typo 'resising' resizing. Will fix in the next iteration. Bartosz