Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3437563pxx; Mon, 2 Nov 2020 08:53:30 -0800 (PST) X-Google-Smtp-Source: ABdhPJwEIq6t3mFay+Nv9AKsT+BgudxDnpFe02Bm/M7wW+qL5LM2ikTZE81wO+BWMnjLHSU8Zn6o X-Received: by 2002:a05:6402:156:: with SMTP id s22mr17588309edu.178.1604336010768; Mon, 02 Nov 2020 08:53:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604336010; cv=none; d=google.com; s=arc-20160816; b=lfyR3DniEFQ8l3GuES2GIPhS7HJRERTMMXk30wmtvZnnFJ7EpeponQJNODnQ4VPvCd NtzcwFI8oPx8mdwSxsFOcurHiR95OHW+a/I5CkhuoDyIXbzgufAViiOnfVZJlIq2irzM JZW1C4X54wezDmGf0hFSxD3FgcF5Ao1wsiYJLPM1C16pME+E/nSiWSRnXdCmw40Gy7HB RB0Bj8XPduK8PljjKRaR1r19rSIl2vRFopgjDpHyUyTtusaXKmDuiu4rGUORFEN4wx43 V7yeflTdcqBHsSBGRP/1ul/WHzvwho9RtpXeiZk70rAL7BWGbfz4U2s8IbIf+XlSjqbM wwJA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=cErhV76ENt4TSg24Fp7Ht7DEbiQDvH5TWJw2QAVKIhM=; b=jWrjuO7dzn9O5BE/aEGuUjpDgC0KVJewXcR/uEopKtlTWPmeA5+4AdMGUJfTc5MopB f556MAteHgjEDl3mrs9p4IAK4HjDljir++dv/YeTO2Mi2GP84x9tNkfzKntlktW3iSFD ZZ8UZGKVThOCIDwiK1aOvsc5GDDXD7dd2KlF2uEFkp8yBfjREVyq1oZsSEHFSxCYcSrY JMeuu5jMVrlUKrU53FkD2ZlMrBJpD7CjAIfU4RLCp8J1KRrOa4NZivOi+WKZtwb61t+i zZk1/uARfxjoJowYgtg9nSCI5o8We4iVdnDHtCW7+nv+ecyu97V6FpAgVtL+mckkGZdp 5wsg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nJYWDgNO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l11si11883858ejx.254.2020.11.02.08.53.07; Mon, 02 Nov 2020 08:53:30 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=nJYWDgNO; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727327AbgKBQvC (ORCPT + 99 others); Mon, 2 Nov 2020 11:51:02 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42828 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727216AbgKBQvC (ORCPT ); Mon, 2 Nov 2020 11:51:02 -0500 Received: from mail-pl1-x643.google.com (mail-pl1-x643.google.com [IPv6:2607:f8b0:4864:20::643]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE44CC0617A6; Mon, 2 Nov 2020 08:51:01 -0800 (PST) Received: by mail-pl1-x643.google.com with SMTP id t6so7085311plq.11; Mon, 02 Nov 2020 08:51:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=cErhV76ENt4TSg24Fp7Ht7DEbiQDvH5TWJw2QAVKIhM=; b=nJYWDgNOZZtlxDlK5ueJ/5vxhAzGVJPLWbe9fkSlizduzmFLoZH0zqf9t3kk2HuA8U lE6tc3WYq/hvTZ0O/dieS6Q0bsdb+ZwDKBi/WGF+MNjDOGgMOOwl9I9+wvij52X2KOd+ A0IfARUHoB8llo6o4QJGAa3UBP3gx5Ug2qQLazIjl9u7OejBgmdVtGzum+CTl/qIPohd vzbAFqVqxo9zbrtVnZ6LWqiAOk0nN93L8q48Eg1TSmA+c6G2URYTrBZxj+k7FnkjHTkB VKsFmh+7Foh3Owu1wa0QQ9xbX8EmHldsQpndxjyfW4Ou2OWc3Uwh/ljhBDnfv/MiEC+i DGbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=cErhV76ENt4TSg24Fp7Ht7DEbiQDvH5TWJw2QAVKIhM=; b=kpTTUbi7UjMnXl83hH/dgbBTL5cDeQUZXrZ+V7yLht+EE10nNp1iEuzA5ol3DUGSxc jkxNodkHunZkw7qr36u5w5rfiqVJujY4V7xaMfFXuyysfwkrLh8FljPkDy7PCQu+tmD0 hIpXzQ1Idz0YeqiUs3ixdg9/EuFDqAmrapzSLnk5vCPUubEdppNtn0x8pdI8qPxz1QtO nEcwbdc8geztmujcjpWr0tMuQJu2i3RsDk6669y2AejmtwMygNUSId65JtTowtipvdFA JPktSfc+kAG91ZbqVnwRuBYJjBuc9vEvmy4MNrIzsNiowuX3rHG9b52eHJOzsGodzL/C BubQ== X-Gm-Message-State: AOAM531uW3KBBSpiFNCYZDBnbiK6QoQr//K3HgdITY/RTOT+djnT/Jz4 wn+kRVL9L8ghj9PumeCVihA= X-Received: by 2002:a17:902:bb81:b029:d5:b437:edb4 with SMTP id m1-20020a170902bb81b02900d5b437edb4mr21167595pls.6.1604335861454; Mon, 02 Nov 2020 08:51:01 -0800 (PST) Received: from varodek.localdomain ([223.179.149.110]) by smtp.gmail.com with ESMTPSA id t74sm4953233pfc.47.2020.11.02.08.50.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Nov 2020 08:51:00 -0800 (PST) From: Vaibhav Gupta To: Bjorn Helgaas , Bjorn Helgaas , Bjorn Helgaas , Vaibhav Gupta , Adam Radford , "James E.J. Bottomley" , "Martin K. Petersen" , Adaptec OEM Raid Solutions , Hannes Reinecke , Bradley Grove , John Garry , Don Brace , Xiang Chen , James Smart , Dick Kennedy , Kashyap Desai , Sumit Saxena , Shivasharan S , Sathya Prakash , Sreekanth Reddy , Suganath Prabu Subramani , Jack Wang , Balsundar P Cc: Vaibhav Gupta , Shuah Khan , linux-kernel@vger.kernel.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-scsi@vger.kernel.org, esc.storagedev@microsemi.com, megaraidlinux.pdl@broadcom.com, MPT-FusionLinux.pdl@broadcom.com Subject: [PATCH v4 04/29] scsi: aacraid: Drop pci_enable_wake() from .resume Date: Mon, 2 Nov 2020 22:17:05 +0530 Message-Id: <20201102164730.324035-5-vaibhavgupta40@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201102164730.324035-1-vaibhavgupta40@gmail.com> References: <20201102164730.324035-1-vaibhavgupta40@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The driver calls pci_enable_wake(...., false) in aac_resume(), and there is no corresponding pci_enable_wake(...., true) in aac_suspend(). Either it should do enable-wake the device in .suspend() or should not invoke pci_enable_wake() at all. Concluding that this is a bug and PCI core calls pci_enable_wake(pci_dev, PCI_D0, false) during resume, drop it from aac_resume(). Signed-off-by: Vaibhav Gupta --- drivers/scsi/aacraid/linit.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/scsi/aacraid/linit.c b/drivers/scsi/aacraid/linit.c index 8f3772480582..8c4dcb5ab329 100644 --- a/drivers/scsi/aacraid/linit.c +++ b/drivers/scsi/aacraid/linit.c @@ -1938,7 +1938,6 @@ static int aac_resume(struct pci_dev *pdev) int r; pci_set_power_state(pdev, PCI_D0); - pci_enable_wake(pdev, PCI_D0, 0); pci_restore_state(pdev); r = pci_enable_device(pdev); -- 2.28.0