Received: by 2002:a05:6a10:9e8c:0:0:0:0 with SMTP id y12csp3478633pxx; Mon, 2 Nov 2020 09:55:47 -0800 (PST) X-Google-Smtp-Source: ABdhPJx3ck5w1OPT5LmjeltLIev+kbw+EALr5eqs3RnvlHBFB4Cus7RcZu54z9fgP8EDhio+Lr9C X-Received: by 2002:a17:906:b216:: with SMTP id p22mr16549300ejz.228.1604339746779; Mon, 02 Nov 2020 09:55:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604339746; cv=none; d=google.com; s=arc-20160816; b=G4pYGW618U7LKTbYMN3I83tmXGHKEw7u+eGJRTkDREZJU2hUGLA0QbRXmowNieJSWk xZnNL6FKgX5rTQ8gkirm2/Z2F+XotFdsuAfVGNXunmk2BrhOh6Lwd7rXetqkt73HYEgP oTYGemzZrgtRWVxqK/VNQ/XAupgbHpYltULbzjRAq2h89JOxKHA57ra2JGSYS1qq8bLt qQvg4oxfqIty70vIKgEDKmCpJleHQZZgDgAE+T7EpfIbWJ9UJD1aqwqLLiHGtA/ROoJB RUnhYSp4ifqJaMXjxgnNWg4j1fOYUOgJUoUTLoQeca24Gyg6R2TbTXYuo8oBIHeTNoJW /ibw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=R6KHY5oGERzlyuTqMgWHXYaiFcamPExo9pzxqfgRYbA=; b=V645JjT3Ih4aNXkoOmBipElT7ngsWQfZUjcYi5Xpq36geBPtL4fmVh6rL01fJLCeby tfKN8H7isDsRePsvUOE4EVpov0RzVf3i5UJ8+6MoRHKB8ENh5YLPN0pJ9pe5ngU75sPN 1msXOwQALyxtUPkJHzlpmF5mMzw80FdzHWwb6wJdLhzPYZZbDP7m8Qbd05XDxAFADPqV WxKsUwiDb+6rxi1U931rKS+sp/utGaVZMo3VR4XOEoJof0q5hOJ2WY+9qcBqssjIw15n 6H/WXSUsf6s88TKAWdOkZJhEsNvolgA5dOY4cr5UdJOkL9T+3ffWK4yhznQl4Xdg9vuL dIWA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FcrsVLmm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id eb13si10888276edb.242.2020.11.02.09.55.24; Mon, 02 Nov 2020 09:55:46 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=FcrsVLmm; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726099AbgKBRxo (ORCPT + 99 others); Mon, 2 Nov 2020 12:53:44 -0500 Received: from mail.kernel.org ([198.145.29.99]:36606 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725852AbgKBRxo (ORCPT ); Mon, 2 Nov 2020 12:53:44 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 670EB2222B; Mon, 2 Nov 2020 17:53:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604339623; bh=pdsobQXNdzfnVTTs+hipelJh7dplYfmBt2Sy9fdVVJA=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=FcrsVLmmz3cHivIctq2dqfSfm3WeHKGi7koMkAkAodRG+oFLkb14lxIV2T40X1OBK 2NHwB/2ETBHlJ/bQkhu2+lgdlsTpDS+kb5pPKsaAuIj2CaDI2+Z9ieA5poMmh4VZs5 31sHEPH9Bvw3fppeKmQBFWHie9TiAwOqNh/N8blU= Date: Mon, 2 Nov 2020 09:53:42 -0800 From: Jakub Kicinski To: Naveen Mamindlapalli Cc: , , , , , , , , Subject: Re: [PATCH net-next 03/13] octeontx2-af: Generate key field bit mask from KEX profile Message-ID: <20201102095342.38c5d5c1@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201102061122.8915-4-naveenm@marvell.com> References: <20201102061122.8915-1-naveenm@marvell.com> <20201102061122.8915-4-naveenm@marvell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2 Nov 2020 11:41:12 +0530 Naveen Mamindlapalli wrote: > From: Subbaraya Sundeep >=20 > Key Extraction(KEX) profile decides how the packet metadata such as > layer information and selected packet data bytes at each layer are > placed in MCAM search key. This patch reads the configured KEX profile > parameters to find out the bit position and bit mask for each field. > The information is used when programming the MCAM match data by SW > to match a packet flow and take appropriate action on the flow. This > patch also verifies the mandatory fields such as channel and DMAC > are not overwritten by the KEX configuration of other fields. >=20 > Signed-off-by: Subbaraya Sundeep > Signed-off-by: Sunil Goutham > Signed-off-by: Naveen Mamindlapalli Lots of new warnings like this here: drivers/net/ethernet/marvell/octeontx2/af/rvu_npc_fs.c:351:38: warning: imp= licit conversion from =E2=80=98enum header_fields=E2=80=99 to =E2=80=98enum= key_fields=E2=80=99 [-Wenum-conversion] 351 | if (npc_check_overlap(rvu, blkaddr, NPC_ETYPE, start_lid, intf)) | ^~~~~~~~~