Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 2 Nov 2020 18:16:55 +0000
From:   Mark Brown <broonie@kernel.org>
To:     Chunyan Zhang <zhang.lyra@gmail.com>
Cc:     linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org,
        Orson Zhai <orsonzhai@gmail.com>,
        Baolin Wang <baolin.wang7@gmail.com>,
        Chunyan Zhang <chunyan.zhang@unisoc.com>,
        Bangzheng Liu <bangzheng.liu@unisoc.com>
Subject: Re: [PATCH] spi: add runtime PM for transfer_one_message
Message-ID: <20201102181655.GC5014@sirena.org.uk>
References: <20201102112239.19218-1-zhang.lyra@gmail.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
        protocol="application/pgp-signature"; boundary="4jXrM3lyYWu4nBt5"
Content-Disposition: inline
In-Reply-To: <20201102112239.19218-1-zhang.lyra@gmail.com>
User-Agent: Mutt/1.10.1 (2018-07-13)
Precedence: bulk


--4jXrM3lyYWu4nBt5
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Mon, Nov 02, 2020 at 07:22:39PM +0800, Chunyan Zhang wrote:
> From: Chunyan Zhang <chunyan.zhang@unisoc.com>

> Before transfer message, spi devices probably have been in runtime suspended,
> that would cause the kernel crash on some platforms once access spi
> registers, such as on Unisoc's SoCs. The spi devices can be suspended
> until message transfer completed.

This commit message is a bit hard to follow so I don't really understand
what the issue is.  We only ever call transfer_one_message() from within
__spi_pump_messages() which already handles auto_runtime_pm so I'm not
seeing the situation where we might get to transfer_one_message()
without having already runtime resumed the controller.  What exactly is
the error situation here?  This code has been around for a while and I'm
not aware of reports of issues here and I can't see anything unusual
that the Spreadtrum driver is doing.

Also why are we doing this in transfer_one_message() where it will only
work for controllers using that?  If we're missing runtime PM in some
paths then presumably controllers with a custom implementation are also
going to be affected as well, auto_runtime_pm is supposed to work for
them as well.

--4jXrM3lyYWu4nBt5
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAl+gTRYACgkQJNaLcl1U
h9DpgQf/fsNdTAx1Ok5mFJtucgRm8rHojszj+RjuRxcRQMQ40rBzWUwhAEpDUj0r
XcYKd9vBWfldbPNj5lNrXTVLdbIB/b2UWL8ixa3Pj5rSnrZ+r2pDl8DuwnimR1Jw
lUjnZz8eBDVHVE6bgZanqn6SSXAX3WTnVo2kRZcSeTksA30xP9SHOSiM6krtQpsm
eUcc3wTHMGHtnQJsucXVnlFcyes3eBN0nzGK4bpmaPUE8QP84JU4ZcIUtY+qMHJ6
FdHUHT3KVzCXb/7dW7llaBWRHeDqLoPBnk8uUQHuwx8fR7CFm1jn2GPfBfocyJSo
i8aObNBlCKwWmShZroUBm3lNRPMclQ==
=YR84
-----END PGP SIGNATURE-----

--4jXrM3lyYWu4nBt5--