Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v7 0/6] Add support for the IEI WT61P803 PUZZLE MCU
To:     Luka Kovacic <luka.kovacic@sartura.hr>, Pavel Machek <pavel@ucw.cz>
CC:     Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        <linux-hwmon@vger.kernel.org>,
        Linux LED Subsystem <linux-leds@vger.kernel.org>,
        devicetree <devicetree@vger.kernel.org>,
        Lee Jones <lee.jones@linaro.org>,
        Rob Herring <robh+dt@kernel.org>,
        Jean Delvare <jdelvare@suse.com>,
        Guenter Roeck <linux@roeck-us.net>,
        Marek Behun <marek.behun@nic.cz>,
        Luka Perkov <luka.perkov@sartura.hr>,
        Andy Shevchenko <andy.shevchenko@gmail.com>,
        Robert Marko <robert.marko@sartura.hr>
References: <20201025005916.64747-7-luka.kovacic@sartura.hr>
 <20201025005916.64747-6-luka.kovacic@sartura.hr>
 <20201025005916.64747-5-luka.kovacic@sartura.hr>
 <20201025005916.64747-4-luka.kovacic@sartura.hr>
 <20201025005916.64747-3-luka.kovacic@sartura.hr>
 <20201025005916.64747-2-luka.kovacic@sartura.hr>
 <20201025005916.64747-1-luka.kovacic@sartura.hr>
 <20201029180105.GD26053@duo.ucw.cz>
 <CADZsf3YE3d=dtMVVYHL91Z1WFcpNN4vyJJ6RG7VnJ2V-DqE+wQ@mail.gmail.com>
From:   Dan Murphy <dmurphy@ti.com>
Message-ID: <7821443b-ddbc-fc92-b990-14d116dda853@ti.com>
Date:   Mon, 2 Nov 2020 12:29:59 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.10.0
MIME-Version: 1.0
In-Reply-To: <CADZsf3YE3d=dtMVVYHL91Z1WFcpNN4vyJJ6RG7VnJ2V-DqE+wQ@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Precedence: bulk

Hello

On 11/1/20 3:56 AM, Luka Kovacic wrote:
> Hello Pavel,
>
> On Thu, Oct 29, 2020 at 7:01 PM Pavel Machek <pavel@ucw.cz> wrote:
>> Hi!
>>
>>> +What:                /sys/bus/serial/devices/.../iei_wt61p803_puzzle_core/power_status
>>> +Date:                September 2020
>>> +Contact:     Luka Kovacic <luka.kovacic@sartura.hr>
>>> +Description: (RO) Power status indicates the host platform power on method.
>>> +             Value mapping (bitwise list):
>>> +             0x80 - Null
>>> +             0x40 - Firmware flag
>>> +             0x20 - Power loss detection flag (powered off)
>>> +             0x10 - Power loss detection flag (AC mode)
>>> +             0x08 - Button power on
>>> +             0x04 - WOL power on
>>> +             0x02 - RTC alarm power on
>>> +             0x01 - AC recover power on
>> It would be nice to put this into standard place somewhere. Many
>> machines will want to expose this information.
> As this is specific to this microcontroller and to how it encodes
> these values, I don't see a need to change this.
> This isn't used anywhere else.
>
>> If not, at least spell out WoL, as it is not that common of acronym.
> Okay.

WoL is a very common acronym especially in the networking space

But the overall this section does not make sense

The description says that it indicates platform power on method but what 
is NULL power on? There are flags for power loss detection.

Does the RTC mean that the processor real time clock woke up the uC? Or 
that the internal RTC woke up the controller?

And for the 
/sys/bus/serial/devices/.../iei_wt61p803_puzzle_core/ac_recovery_status 
what are those values?

It seems like some ABI's are documented well with formats and others are 
just described without a format.

For instance

/sys/bus/serial/devices/.../iei_wt61p803_puzzle_core/version the format 
of this version is not described but 
/sys/bus/serial/devices/.../iei_wt61p803_puzzle_core/build_info is.


Dan