Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v2] nitro_enclaves: Fixup type and simplify logic of the
 poll mask setup
To:     Alexander Graf <graf@amazon.de>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC:     Anthony Liguori <aliguori@amazon.com>,
        Benjamin Herrenschmidt <benh@kernel.crashing.org>,
        Colm MacCarthaigh <colmmacc@amazon.com>,
        "David Duncan" <davdunc@amazon.com>,
        Bjoern Doebel <doebel@amazon.de>,
        "David Woodhouse" <dwmw@amazon.co.uk>,
        Frank van der Linden <fllinden@amazon.com>,
        Karen Noel <knoel@redhat.com>,
        Martin Pohlack <mpohlack@amazon.de>,
        "Matt Wilson" <msw@amazon.com>,
        Paolo Bonzini <pbonzini@redhat.com>,
        "Stefano Garzarella" <sgarzare@redhat.com>,
        Stefan Hajnoczi <stefanha@redhat.com>,
        Stewart Smith <trawets@amazon.com>,
        Uwe Dannowski <uwed@amazon.de>,
        "Vitaly Kuznetsov" <vkuznets@redhat.com>,
        kvm <kvm@vger.kernel.org>,
        ne-devel-upstream <ne-devel-upstream@amazon.com>
References: <20201102173622.32169-1-andraprs@amazon.com>
 <405f71a6-9699-759d-2398-a17120d3fb96@amazon.de>
From:   "Paraschiv, Andra-Irina" <andraprs@amazon.com>
Message-ID: <e78692ac-9133-055c-05aa-0cfd213fd5d8@amazon.com>
Date:   Mon, 2 Nov 2020 20:29:20 +0200
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:78.0)
 Gecko/20100101 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <405f71a6-9699-759d-2398-a17120d3fb96@amazon.de>
Content-Language: en-US
Content-Type: text/plain; charset="windows-1252"; format="flowed"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk


On 02/11/2020 19:50, Alexander Graf wrote:
>
>
> On 02.11.20 18:36, Andra Paraschiv wrote:
>> Update the assigned value of the poll result to be EPOLLHUP instead of
>> POLLHUP to match the __poll_t type.
>>
>> While at it, simplify the logic of setting the mask result of the poll
>> function.
>>
>> Changelog
>>
>> v1 -> v2
>>
>> * Simplify the mask setting logic from the poll function.
>>
>> Signed-off-by: Andra Paraschiv <andraprs@amazon.com>
>> Reported-by: kernel test robot <lkp@intel.com>
>
> Reviewed-by: Alexander Graf <graf@amazon.com>
>
>

Greg, let me know if there is anything remaining to be done for this =

patch. Otherwise, can you please add the patch to the char-misc tree.

Thanks,
Andra

>
>> ---
>> =A0 drivers/virt/nitro_enclaves/ne_misc_dev.c | 6 ++----
>> =A0 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/virt/nitro_enclaves/ne_misc_dev.c =

>> b/drivers/virt/nitro_enclaves/ne_misc_dev.c
>> index f06622b48d695..f1964ea4b8269 100644
>> --- a/drivers/virt/nitro_enclaves/ne_misc_dev.c
>> +++ b/drivers/virt/nitro_enclaves/ne_misc_dev.c
>> @@ -1505,10 +1505,8 @@ static __poll_t ne_enclave_poll(struct file =

>> *file, poll_table *wait)
>> =A0 =A0=A0=A0=A0=A0 poll_wait(file, &ne_enclave->eventq, wait);
>> =A0 -=A0=A0=A0 if (!ne_enclave->has_event)
>> -=A0=A0=A0=A0=A0=A0=A0 return mask;
>> -
>> -=A0=A0=A0 mask =3D POLLHUP;
>> +=A0=A0=A0 if (ne_enclave->has_event)
>> +=A0=A0=A0=A0=A0=A0=A0 mask |=3D EPOLLHUP;
>> =A0 =A0=A0=A0=A0=A0 return mask;
>> =A0 }
>>


Amazon Development Center (Romania) S.R.L. registered office: 27A Sf. Lazar=
 Street, UBC5, floor 2, Iasi, Iasi County, 700045, Romania. Registered in R=
omania. Registration number J22/2621/2005.