Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201101153647.2292322-1-trix@redhat.com>
In-Reply-To: <20201101153647.2292322-1-trix@redhat.com>
From:   Andrii Nakryiko <andrii.nakryiko@gmail.com>
Date:   Mon, 2 Nov 2020 10:59:47 -0800
Message-ID: <CAEf4BzY+_aqCpww9ZCHOMCnunvWrszWTUFDP=cEy2CY75S1yRg@mail.gmail.com>
Subject: Re: [PATCH] net: core: remove unneeded semicolon
To:     trix@redhat.com
Cc:     "David S. Miller" <davem@davemloft.net>,
        Jakub Kicinski <kuba@kernel.org>,
        Alexei Starovoitov <ast@kernel.org>,
        Andrii Nakryiko <andriin@fb.com>,
        Eric Dumazet <edumazet@google.com>, ap420073@gmail.com,
        Cong Wang <xiyou.wangcong@gmail.com>, jiri@mellanox.com,
        Maxim Mikityanskiy <maximmi@mellanox.com>,
        Networking <netdev@vger.kernel.org>,
        open list <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Sun, Nov 1, 2020 at 7:38 AM <trix@redhat.com> wrote:
>
> From: Tom Rix <trix@redhat.com>
>
> A semicolon is not needed after a switch statement.
>
> Signed-off-by: Tom Rix <trix@redhat.com>
> ---

Yep.

Acked-by: Andrii Nakryiko <andrii@kernel.org>

>  net/core/dev.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/core/dev.c b/net/core/dev.c
> index 751e5264fd49..10f5d0c3d0d7 100644
> --- a/net/core/dev.c
> +++ b/net/core/dev.c
> @@ -8898,7 +8898,7 @@ static bpf_op_t dev_xdp_bpf_op(struct net_device *dev, enum bpf_xdp_mode mode)
>                 return dev->netdev_ops->ndo_bpf;
>         default:
>                 return NULL;
> -       };
> +       }
>  }
>
>  static struct bpf_xdp_link *dev_xdp_link(struct net_device *dev,
> --
> 2.18.1
>