Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <1604318927-11896-1-git-send-email-zou_wei@huawei.com>
In-Reply-To: <1604318927-11896-1-git-send-email-zou_wei@huawei.com>
From:   Alex Deucher <alexdeucher@gmail.com>
Date:   Mon, 2 Nov 2020 14:04:29 -0500
Message-ID: <CADnq5_OLB62R9NA_n6JW5vJQPANmBXD6DapMvP74i=amevxE1Q@mail.gmail.com>
Subject: Re: [PATCH -next] drm/amd/pm: remove unused variable
To:     Zou Wei <zou_wei@huawei.com>
Cc:     "Deucher, Alexander" <alexander.deucher@amd.com>,
        Christian Koenig <christian.koenig@amd.com>,
        Dave Airlie <airlied@linux.ie>,
        Daniel Vetter <daniel@ffwll.ch>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        amd-gfx list <amd-gfx@lists.freedesktop.org>,
        Xiaojian Du <Xiaojian.Du@amd.com>,
        LKML <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk

On Mon, Nov 2, 2020 at 8:44 AM Zou Wei <zou_wei@huawei.com> wrote:
>
> Fix variable set but not used compilation warning:
>
> ./vangogh_ppt.c:397:6: warning: variable =E2=80=98ret=E2=80=99 set but no=
t used [-Wunused-but-set-variable]
>   int ret =3D 0;
>       ^~~
>

Maybe you have an older version of the code?  It's currently used.

Alex


> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Zou Wei <zou_wei@huawei.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c b/drivers/g=
pu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> index 6e26025..355ade5 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/vangogh_ppt.c
> @@ -394,8 +394,6 @@ static int vangogh_get_current_activity_percent(struc=
t smu_context *smu,
>                                                enum amd_pp_sensors sensor=
,
>                                                uint32_t *value)
>  {
> -       int ret =3D 0;
> -
>         if (!value)
>                 return -EINVAL;
>
> --
> 2.6.2
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel