Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Sender: Valdis Kletnieks <valdis@vt.edu>
From:   "Valdis Kl=?utf-8?Q?=c4=93?=tnieks" <valdis.kletnieks@vt.edu>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Dong Aisheng <aisheng.dong@nxp.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Shawn Guo <shawnguo@kernel.org>,
        Stephen Boyd <sboyd@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] clk: imx: scu: Fix compile error with module build of clk-scu.o
In-Reply-To: <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org>
References: <208469.1604318525@turing-police>
 <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org>
Mime-Version: 1.0
Content-Type: multipart/signed; boundary="==_Exmh_1604350899_216810P";
         micalg=pgp-sha1; protocol="application/pgp-signature"
Content-Transfer-Encoding: 7bit
Date:   Mon, 02 Nov 2020 16:01:39 -0500
Message-ID: <238534.1604350899@turing-police>
Precedence: bulk

--==_Exmh_1604350899_216810P
Content-Type: text/plain; charset=us-ascii

On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said:

> also
> Reported-by: kernel test robot <lkp@intel.com>
>
> However, this driver does not directly use <linux/module.h>.

Just my luck - I looked at 3 or 4 other things that include of_platform.h
and they all *did* include module.h.

> platform_device.h #includes <linux/device.h>, which is where the
> problem lies:
>
> <linux/device.h> uses macros that are provided by <linux/module.h>
> so <linux/device.h> should #include <linux/module.h>.
>
> and that fixes this commit:
>
> commit 4c002c978b7f2f2306d53de051c054504af920a9
> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Date:   Mon Dec 9 20:33:03 2019 +0100
>
>     device.h: move 'struct driver' stuff out to device/driver.h

OK.. who's going to do that? Me, or Randy, or Greg?


--==_Exmh_1604350899_216810P
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Comment: Exmh version 2.9.0 11/07/2018

iQIVAwUBX6BzsgdmEQWDXROgAQKfjg//RIaEOb6EyTQqKOPfGtJ4KcMOdHgJwcC/
tYMiOn2Em2wycFf71WP/tBsIDqUXcPVUDfU5zyQPYPKjbRJjMUe1PraO3qrSlhke
N6XwkcCo4V16PVFJFpcdVJfxo6nPxlIZ9lq3Hd4T26gnUPfS9p5rPHtGNYDAKyD8
c3mlwDN3inQnuBuON73p7pS+OopVJHjmU6zvvEgbsiJcUpoJk+13uKvTG4RbWmNz
i1PKb1+dk4uEETAZCMftFqfji80ugWUuMXKRCapS12nqBOkLgxUmWED5XZJC4H5X
pogktUAGKxTivLqhVTz/JWvrAnACKiM1OUfRCNcJh40hgt3wGvuUxLpALT2Rfiqp
ANRl4q2UzivUIhbee+V9h4m+ZthBkOmHU7nfDQDeZYzKHAGthUfKGdmTXEG2dAmH
R5p7E/k4GfKvBdGYp86LL/s+wlARvqbfg/R0fTIlsTgfPsnOkigP41s5w0Ccm656
7YIXHJomsOL8cjWyvLI/FpbhFs92c11Pt8nlKj2PEl+M9GjoL7gp7NSSJM7DaEri
UrEcmlaNN12hu5giSsJ7N1olVqkgMqylM0JptP33eObCC5uHx+Tz/sOWpFrKCuBi
kZVXKKFL6QOe/fAVvYPfcP1ThTbRv5Giv4iDLVB6AXxre74nb7QbUYPDeu18DIMv
bcY4c26AjmI=
=PXZH
-----END PGP SIGNATURE-----

--==_Exmh_1604350899_216810P--