Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
MIME-Version: 1.0
References: <20201029053959.31361-1-vidyas@nvidia.com> <20201029053959.31361-3-vidyas@nvidia.com>
 <CAL_Jsq+3Ek9SRbsTqEmjiZtszvi7Er=TNgOt8t=0OESva2=sTg@mail.gmail.com>
 <902c0445-9fed-8e61-3aba-0e87988eb8df@nvidia.com> <DM5PR12MB18357E6BF282C9C65278460EDA100@DM5PR12MB1835.namprd12.prod.outlook.com>
In-Reply-To: <DM5PR12MB18357E6BF282C9C65278460EDA100@DM5PR12MB1835.namprd12.prod.outlook.com>
From:   Rob Herring <robh@kernel.org>
Date:   Mon, 2 Nov 2020 15:16:52 -0600
Message-ID: <CAL_Jsq+jH_bwv2dQrY-O4PTD1kK=BMObLjH_NFmfG8kQUUpD8Q@mail.gmail.com>
Subject: Re: [PATCH V3 2/2] PCI: dwc: Add support to configure for ECRC
To:     Gustavo Pimentel <Gustavo.Pimentel@synopsys.com>
Cc:     Vidya Sagar <vidyas@nvidia.com>, Jingoo Han <jingoohan1@gmail.com>,
        Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>,
        Bjorn Helgaas <bhelgaas@google.com>,
        Andrew Murray <amurray@thegoodpenguin.co.uk>,
        Thierry Reding <treding@nvidia.com>,
        Jon Hunter <jonathanh@nvidia.com>,
        PCI <linux-pci@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "kthota@nvidia.com" <kthota@nvidia.com>,
        Manikanta Maddireddy <mmaddireddy@nvidia.com>,
        "sagar.tv@gmail.com" <sagar.tv@gmail.com>
Content-Type: text/plain; charset="UTF-8"
Precedence: bulk

On Mon, Nov 2, 2020 at 9:12 AM Gustavo Pimentel
<Gustavo.Pimentel@synopsys.com> wrote:
>
> On Mon, Nov 2, 2020 at 14:27:9, Vidya Sagar <vidyas@nvidia.com> wrote:
>
> >
> >
> > On 11/2/2020 7:45 PM, Rob Herring wrote:
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > On Thu, Oct 29, 2020 at 12:40 AM Vidya Sagar <vidyas@nvidia.com> wrote:
> > >>
> > >> DesignWare core has a TLP digest (TD) override bit in one of the control
> > >> registers of ATU. This bit also needs to be programmed for proper ECRC
> > >> functionality. This is currently identified as an issue with DesignWare
> > >> IP version 4.90a. This patch does the required programming in ATU upon
> > >> querying the system policy for ECRC.
> > >>
> > >> Signed-off-by: Vidya Sagar <vidyas@nvidia.com>
> > >> Reviewed-by: Jingoo Han <jingoohan1@gmail.com>
> > >> ---
> > >> V3:
> > >> * Added 'Reviewed-by: Jingoo Han <jingoohan1@gmail.com>'
> > >>
> > >> V2:
> > >> * Addressed Jingoo's review comment
> > >> * Removed saving 'td' bit information in 'dw_pcie' structure
> > >>
> > >>   drivers/pci/controller/dwc/pcie-designware.c | 8 ++++++--
> > >>   drivers/pci/controller/dwc/pcie-designware.h | 1 +
> > >>   2 files changed, 7 insertions(+), 2 deletions(-)
> > >>
> > >> diff --git a/drivers/pci/controller/dwc/pcie-designware.c b/drivers/pci/controller/dwc/pcie-designware.c
> > >> index b5e438b70cd5..cbd651b219d2 100644
> > >> --- a/drivers/pci/controller/dwc/pcie-designware.c
> > >> +++ b/drivers/pci/controller/dwc/pcie-designware.c
> > >> @@ -246,6 +246,8 @@ static void dw_pcie_prog_outbound_atu_unroll(struct dw_pcie *pci, u8 func_no,
> > >>          dw_pcie_writel_ob_unroll(pci, index, PCIE_ATU_UNR_UPPER_TARGET,
> > >>                                   upper_32_bits(pci_addr));
> > >>          val = type | PCIE_ATU_FUNC_NUM(func_no);
> > >> +       if (pci->version == 0x490A)
> > >> +               val = val | pcie_is_ecrc_enabled() << PCIE_ATU_TD_SHIFT;
> > >>          val = upper_32_bits(size - 1) ?
> > >>                  val | PCIE_ATU_INCREASE_REGION_SIZE : val;
> > >>          dw_pcie_writel_ob_unroll(pci, index, PCIE_ATU_UNR_REGION_CTRL1, val);
> > >> @@ -294,8 +296,10 @@ static void __dw_pcie_prog_outbound_atu(struct dw_pcie *pci, u8 func_no,
> > >>                             lower_32_bits(pci_addr));
> > >>          dw_pcie_writel_dbi(pci, PCIE_ATU_UPPER_TARGET,
> > >>                             upper_32_bits(pci_addr));
> > >> -       dw_pcie_writel_dbi(pci, PCIE_ATU_CR1, type |
> > >> -                          PCIE_ATU_FUNC_NUM(func_no));
> > >> +       val = type | PCIE_ATU_FUNC_NUM(func_no);
> > >> +       if (pci->version == 0x490A)
> > >
> > > Is this even possible? Are the non-unroll ATU registers available post 4.80?
> > I'm not sure. Gustavo might have information about this. I made this
> > change so that it is taken care off even if they available.
>
> The Synopsys DesignWare PCIe IP is highly configurable, therefore is
> dependable on what the design team has configured for their solution.
> Although Synopsys doesn't recommend the use of non-unroll ATU, the
> customers are free to select what they want for their design.

Okay, then there's a bug in the driver if the version is set to 0x480A
or later and non-unroll is used:

if (pci->version >= 0x480A || (!pci->version &&
       dw_pcie_iatu_unroll_enabled(pci))) {

Probably can just drop the version checking. The detection should always work.

Rob