Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 2 Nov 2020 14:08:08 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Vladimir Oltean <vladimir.oltean@nxp.com>
Cc:     Pujin Shi <shipujin.t@gmail.com>,
        "David S . Miller" <davem@davemloft.net>,
        Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
        Claudiu Manoil <claudiu.manoil@nxp.com>,
        Alexandre Belloni <alexandre.belloni@bootlin.com>,
        Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: ethernet: mscc: fix missing brace warning for old
 compilers
Message-ID: <20201102140808.54c156fa@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20201102135654.gs2fa7q2y3i3sc5k@skbuf>
References: <20201102134136.2565-1-shipujin.t@gmail.com>
        <20201102135654.gs2fa7q2y3i3sc5k@skbuf>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2 Nov 2020 13:56:55 +0000 Vladimir Oltean wrote:
> On Mon, Nov 02, 2020 at 09:41:36PM +0800, Pujin Shi wrote:
> > For older versions of gcc, the array = {0}; will cause warnings:
> > 
> > drivers/net/ethernet/mscc/ocelot_vcap.c: In function 'is1_entry_set':
> > drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: missing braces around initializer [-Wmissing-braces]
> >     struct ocelot_vcap_u16 etype = {0};
> >            ^
> > drivers/net/ethernet/mscc/ocelot_vcap.c:755:11: warning: (near initialization for 'etype.value') [-Wmissing-braces]
> > 
> > 1 warnings generated
> > 
> > Fixes: 75944fda1dfe ("net: mscc: ocelot: offload ingress skbedit and vlan actions to VCAP IS1")
> > Signed-off-by: Pujin Shi <shipujin.t@gmail.com>
> > ---
> >  drivers/net/ethernet/mscc/ocelot_vcap.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/net/ethernet/mscc/ocelot_vcap.c b/drivers/net/ethernet/mscc/ocelot_vcap.c
> > index d8c778ee6f1b..b96eab4583e7 100644
> > --- a/drivers/net/ethernet/mscc/ocelot_vcap.c
> > +++ b/drivers/net/ethernet/mscc/ocelot_vcap.c
> > @@ -752,7 +752,7 @@ static void is1_entry_set(struct ocelot *ocelot, int ix,
> >  					     dport);
> >  		} else {
> >  			/* IPv4 "other" frame */
> > -			struct ocelot_vcap_u16 etype = {0};
> > +			struct ocelot_vcap_u16 etype = {};
> >  
> 
> Sorry, I don't understand what the problem is, or why your patch fixes
> it. What version of gcc are you testing with?

Old GCC does not like the 0, if the members of struct are not scalars.

struct ocelot_vcap_u16 {                                                        
        u8 value[2];                                                            
        u8 mask[2];                                                             
};

In this case the first member is an array.

It wants us to add another curly brace:

struct ocelot_vcap_u16 etype = {{0}};

... or we can just skip the 0.

That's just FWIW. I don't remember which versions of GCC behave like
that, I just know we get a constant stream of this sort of fixes.
I think clang may generate a similar warning.

Pujin, please specify the version of GCC you're using and repost.