Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Mon, 2 Nov 2020 15:05:28 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
Cc:     Petr Malat <oss@malat.biz>, linux-sctp@vger.kernel.org,
        Vlad Yasevich <vyasevich@gmail.com>,
        Neil Horman <nhorman@tuxdriver.com>,
        "David S. Miller" <davem@davemloft.net>, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sctp: Fix COMM_LOST/CANT_STR_ASSOC err reporting on
 big-endian platforms
Message-ID: <20201102150528.59f13386@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20201102132717.GI11030@localhost.localdomain>
References: <20201030132633.7045-1-oss@malat.biz>
        <20201102132717.GI11030@localhost.localdomain>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2 Nov 2020 10:27:17 -0300 Marcelo Ricardo Leitner wrote:
> On Fri, Oct 30, 2020 at 02:26:33PM +0100, Petr Malat wrote:
> > Commit 978aa0474115 ("sctp: fix some type cast warnings introduced since
> > very beginning")' broke err reading from sctp_arg, because it reads the
> > value as 32-bit integer, although the value is stored as 16-bit integer.
> > Later this value is passed to the userspace in 16-bit variable, thus the
> > user always gets 0 on big-endian platforms. Fix it by reading the __u16
> > field of sctp_arg union, as reading err field would produce a sparse
> > warning.  
> 
> Makes sense.
> 
> > 
> > Signed-off-by: Petr Malat <oss@malat.biz>  
> 
> Then, it also needs:
> Fixes: 978aa0474115 ("sctp: fix some type cast warnings introduced since very beginning")'
> 
> Acked-by: Marcelo Ricardo Leitner <marcelo.leitner@gmail.com>
> (If the maintainers can't add the Fixes tag above, please keep the ack
> on the v2)

Applied, thanks!