Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp101151pxb; Mon, 2 Nov 2020 15:18:59 -0800 (PST) X-Google-Smtp-Source: ABdhPJyhoSZk8nTQIqEbz8bTDMwrbTC4bh6XIXVF0Nqno19kOdjUBevGuPwvZeXxrvymY03Nu6jX X-Received: by 2002:a17:906:a1d8:: with SMTP id bx24mr17064746ejb.161.1604359139224; Mon, 02 Nov 2020 15:18:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604359139; cv=none; d=google.com; s=arc-20160816; b=0ZzD7D9X479ZbeytGIRDA/m9ImqdJu6H5DoasebFXRkGYIdi4tiGRzmswKyGJqlZ0c VYbWzuzu26QguUBpIcCoE3k9jL4XzFxJItMrLpD/mg04BYMZmBJdI1GwPreqH7fK4hDK rtvxdBoHU3q5Go08OPDq6OHayTX9yGEz0d8USirR4r4ISL4D4TqVtStxgp1XVQUJKh+u S44Fde5HB33F+jlaxkMyV2uhtm66oHwVQs8SWgIh5uH2l31VLBzc9/jI7kdchum/kcTz havUnGtiV7slEndy1qRiqyFPB2HfDVhGKKS+bdewH1HrBgkj802f2sYy1lPX+bSanBoT 1OsQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:subject:cc:to:from:date :dkim-signature; bh=bgFAbIDXVw3gHIaLYRztKRpgt9gFY/XahzdtG0PT/NI=; b=BMjMv9DQo9uKX3niTac5xia1yLWqoLXvPNEuF9kKHSSInzWugCpIV5op2L5JDOxkA5 UHoHvwp/svVR+secpFDy9XDNLo9Qsv1+aO7fQ+wu67CYk8n5qnLKHe4Mw+03sTCjqRhK +JG4eA7T0WgkWfuzq8VMJOfxQiHMIDiKVsqQOXhfvmjHfBxM/QRNNafGIsfbKKoiKtUp VH3oELs/qEj5Mj/FW1mhqpLTby/oiqSOs3LqTBqZiEexWBuh3VzI4m/xQTm2RP0wF240 pjZB5kobHue12SGCt7DLUvBd8wO21Do+blDUkGMssK4F53wblTecT+vZU4hT3acApoDb W8Aw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=grXap7UG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id h13si5278965edn.268.2020.11.02.15.18.37; Mon, 02 Nov 2020 15:18:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=grXap7UG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726837AbgKBXRK (ORCPT + 99 others); Mon, 2 Nov 2020 18:17:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:60376 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725831AbgKBXRJ (ORCPT ); Mon, 2 Nov 2020 18:17:09 -0500 Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E53092225E; Mon, 2 Nov 2020 23:17:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604359029; bh=biCUf2cUK9m86UfR7bxkBHVCbJwZo+y2Vceg1KkmJrE=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=grXap7UGdDL0yZ+h8E49WNyBO5LPij3L+M4P3YIH+ydYIXCIyzh2Rfem111ZJ+O4p 5/Lug/TrJtvI53zgv++REM9yEppgNTVZ84dv5xdRO18CNGyXN0V8N2MiQDU32jet4n 7n5Gd9EKREM6l0ey61fAG6guIO6tLmv0QJqmWCAk= Date: Mon, 2 Nov 2020 15:17:07 -0800 From: Jakub Kicinski To: Andrew Lunn Cc: Jonathan McDowell , DENG Qingfang , Vladimir Oltean , Vivien Didelot , Florian Fainelli , David Miller , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net] net: dsa: qca8k: Fix port MTU setting Message-ID: <20201102151707.2357185b@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net> In-Reply-To: <20201030184733.GB1042051@lunn.ch> References: <20201030183315.GA6736@earth.li> <20201030184733.GB1042051@lunn.ch> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 30 Oct 2020 19:47:33 +0100 Andrew Lunn wrote: > On Fri, Oct 30, 2020 at 06:33:15PM +0000, Jonathan McDowell wrote: > > The qca8k only supports a switch-wide MTU setting, and the code to take > > the max of all ports was only looking at the port currently being set. > > Fix to examine all ports. > > > > Reported-by: DENG Qingfang > > Fixes: f58d2598cf70 ("net: dsa: qca8k: implement the port MTU callbacks") > > Cc: stable@vger.kernel.org > > Signed-off-by: Jonathan McDowell > > Reviewed-by: Andrew Lunn Applied, thanks!