Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 3 Nov 2020 07:52:19 +0800
From:   Shawn Guo <shawnguo@kernel.org>
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Valdis =?utf-8?Q?Kl=C4=93tnieks?= <valdis.kletnieks@vt.edu>,
        Dong Aisheng <aisheng.dong@nxp.com>,
        Michael Turquette <mturquette@baylibre.com>,
        Stephen Boyd <sboyd@kernel.org>,
        Sascha Hauer <s.hauer@pengutronix.de>,
        linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
        linux-kernel@vger.kernel.org,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] clk: imx: scu: Fix compile error with module build of
 clk-scu.o
Message-ID: <20201102235218.GY31601@dragon>
References: <208469.1604318525@turing-police>
 <6e5a8fdb-0a02-5eae-ca1f-37df8a454e34@infradead.org>
 <238534.1604350899@turing-police>
 <0b61c4f4-b389-c853-6e09-ee603455e583@infradead.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <0b61c4f4-b389-c853-6e09-ee603455e583@infradead.org>
User-Agent: Mutt/1.9.4 (2018-02-28)
Precedence: bulk

On Mon, Nov 02, 2020 at 01:31:59PM -0800, Randy Dunlap wrote:
> On 11/2/20 1:01 PM, Valdis Klētnieks wrote:
> > On Mon, 02 Nov 2020 09:15:20 -0800, Randy Dunlap said:
> > 
> >> also
> >> Reported-by: kernel test robot <lkp@intel.com>
> >>
> >> However, this driver does not directly use <linux/module.h>.
> > 
> > Just my luck - I looked at 3 or 4 other things that include of_platform.h
> > and they all *did* include module.h.
> > 
> >> platform_device.h #includes <linux/device.h>, which is where the
> >> problem lies:
> >>
> >> <linux/device.h> uses macros that are provided by <linux/module.h>
> >> so <linux/device.h> should #include <linux/module.h>.
> >>
> >> and that fixes this commit:
> >>
> >> commit 4c002c978b7f2f2306d53de051c054504af920a9
> >> Author: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> >> Date:   Mon Dec 9 20:33:03 2019 +0100
> >>
> >>     device.h: move 'struct driver' stuff out to device/driver.h
> > 
> > OK.. who's going to do that? Me, or Randy, or Greg?
> 
> You could go ahead... I began on it yesterday but didn't finish
> testing, although I did see the same build error that the 0day
> bot reported, so I don't know what it's going to take to fix that.

It's a driver problem which is being addressed by Dong's patch[1].

Shawn

[1] https://patchwork.kernel.org/project/linux-arm-kernel/patch/20201030153733.30160-1-aisheng.dong@nxp.com/