Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Andreas Dilger <adilger@dilger.ca>
Message-Id: <7CCB9FA6-DE85-4E3F-B3F1-7144F01589D4@dilger.ca>
Content-Type: multipart/signed;
 boundary="Apple-Mail=_371D7085-4417-47D2-9B58-9CE8331344FA";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Mime-Version: 1.0 (Mac OS X Mail 10.3 \(3273\))
Subject: Re: [PATCH v2] fs/aio.c: Cosmetic
Date:   Mon, 2 Nov 2020 17:50:46 -0700
In-Reply-To: <20201102215809.17312-1-colomar.6.4.3@gmail.com>
Cc:     Benjamin LaHaise <bcrl@kvack.org>, linux-aio@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
To:     Alejandro Colomar <colomar.6.4.3@gmail.com>
References: <20201102152439.315640-1-colomar.6.4.3@gmail.com>
 <20201102215809.17312-1-colomar.6.4.3@gmail.com>
Precedence: bulk


--Apple-Mail=_371D7085-4417-47D2-9B58-9CE8331344FA
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain;
	charset=us-ascii

On Nov 2, 2020, at 2:58 PM, Alejandro Colomar <colomar.6.4.3@gmail.com> =
wrote:
> Changes:
> - Consistently use 'unsigned int', instead of 'unsigned'.
> - Add a blank line after variable declarations.
> - Move variable declarations to the top of functions.
> - Add a blank line at the top of functions if there are no =
declarations.

I'd agree that the other changes are following kernel coding style, but
I've never heard of leaving a blank line at the start of functions =
without
any local variables.  I don't see anything in process/coding-style.rst =
to
support this change, nor are the majority of variable-less functions
formatted this way, and it seems to just be a waste of vertical space.

Cheers, Andreas


--Apple-Mail=_371D7085-4417-47D2-9B58-9CE8331344FA
Content-Transfer-Encoding: 7bit
Content-Disposition: attachment;
	filename=signature.asc
Content-Type: application/pgp-signature;
	name=signature.asc
Content-Description: Message signed with OpenPGP

-----BEGIN PGP SIGNATURE-----
Comment: GPGTools - http://gpgtools.org

iQIzBAEBCAAdFiEEDb73u6ZejP5ZMprvcqXauRfMH+AFAl+gqWcACgkQcqXauRfM
H+A9QA/7BMfqa7d4Rxvdvr8ROUPltUp3AL93VOvAfuFCPAZK9O356Qo3SdLHFBKP
GFbyf1idAIL+e71wdJuRGwE3nD2q1OUl5c7K8ajjRNtuxO8FIahqjhfrSbnwsLwl
a4QiO6uZRTA9q8ByeXvCQntnkHqSTFg1GZO8OCvVaT/nv6YP0DLu2AwIJaIdcjme
5HSPh6BG8YlIOq13GbLb1JxQwbYUViszEW1pHQ4uDxMcXnZR4icUabandQ7Kat3m
4mH4M3n3ti6Lh7Sf+enajsznZAXeVCaRCgk2OklyymNzl8jYduKNrOPBo4jK8yU2
0knidVldo16pa0f7nGrhbYG3nUO+gYXVrF7nO2SwUj3k1AAU1sHvh1kR9sZ8r+eJ
53qqFdSHkCKK+cWj5PtBMwC/ljEiDU3oMrM/X25giKKxLV2GdKe+hGy+MphghhZL
3TYNHYdeUiVhIIzW9U+kZEWdK89hqSplC7B3xMF1ubzRJkcX6WD6o1iB8z0kERWr
eUZMQeMpLOR/vFGdks3+Z0hgS9IqbtPtk9guJlFVGqkY5r023lT8w4kWmpDubuDa
XzNkPu/j3TZ2oVmCgzzzi01ckZ9l/u9elOtzjFv16QOQLcjAatSbgg36ixNVbC50
SiR+OMMNYmPSBfl4p0g2fg5e/aUOAvqNPcVWcp/6++t+nWf8AMM=
=HCM2
-----END PGP SIGNATURE-----

--Apple-Mail=_371D7085-4417-47D2-9B58-9CE8331344FA--