Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
From:   Peng Fan <peng.fan@nxp.com>
To:     Shawn Guo <shawnguo@kernel.org>
CC:     "sboyd@kernel.org" <sboyd@kernel.org>,
        "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
        "festevam@gmail.com" <festevam@gmail.com>,
        Abel Vesa <abel.vesa@nxp.com>,
        "kernel@pengutronix.de" <kernel@pengutronix.de>,
        dl-linux-imx <linux-imx@nxp.com>,
        Anson Huang <anson.huang@nxp.com>,
        "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>,
        "linux-arm-kernel@lists.infradead.org" 
        <linux-arm-kernel@lists.infradead.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Aisheng Dong <aisheng.dong@nxp.com>
Subject: RE: [PATCH V3] clk: imx8m: fix bus critical clk registration
Thread-Topic: [PATCH V3] clk: imx8m: fix bus critical clk registration
Thread-Index: AQHWsEJPSa9ZZa+Apk613nP3qyZAk6m1ifiAgAAPrCA=
Date:   Tue, 3 Nov 2020 01:03:44 +0000
Message-ID: <DB6PR0402MB2760920568B1FC6A9F993EFB88110@DB6PR0402MB2760.eurprd04.prod.outlook.com>
References: <1604229834-25594-1-git-send-email-peng.fan@nxp.com>
 <20201103000657.GA31601@dragon>
In-Reply-To: <20201103000657.GA31601@dragon>
Accept-Language: en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: c53d453f-db70-482f-b398-08d87f944fbb
X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Nov 2020 01:03:44.1004
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: flwLUlnCRzol1/y46O2RgasJEdM88QJAZIO+einoBrB8tsUIINT77vA5FxafEMI+TQkupV9XvgYLJ2FYdQvk1Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR04MB3125
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Shawn,

> Subject: Re: [PATCH V3] clk: imx8m: fix bus critical clk registration
>=20
> On Sun, Nov 01, 2020 at 07:23:54PM +0800, peng.fan@nxp.com wrote:
> > From: Peng Fan <peng.fan@nxp.com>
> >
> > noc/axi/ahb are bus clk, not peripheral clk.
> > Since peripheral clk has a limitation that for peripheral clock slice,
> > IP clock slices must be stopped to change the clock source.
> >
> > However if the bus clk is marked as critical clk peripheral, the
> > assigned clock parent operation will fail.
> >
> > So we added CLK_SET_PARENT_GATE flag to avoid glitch.
> >
> > And add imx8m_clk_hw_composite_bus_critical for bus critical clock
> > usage
> >
> > Fixes: 936c383673b9e ("clk: imx: fix composite peripheral flags")
> > Reviewed-by: Abel Vesa <abel.vesa@nxp.com>
> > Reported-by: Abel Vesa <abel.vesa@nxp.com>
> > Signed-off-by: Peng Fan <peng.fan@nxp.com>
>=20
> Do you want this be picked up as a fix for 5.10-rc or non-critical stuff =
for
> -next?

Please take this as a fix for 5.10-rc.

Thanks,
Peng.

>=20
> Shawn