Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp164043pxb;
        Mon, 2 Nov 2020 17:25:54 -0800 (PST)
X-Google-Smtp-Source: ABdhPJxTAx3SX/bamMOo0ZM4K3o4bf0JSWKbDmpdqfYNf1kBiUzLkpLQSZOdqqFGrZaHNmU68GV0
X-Received: by 2002:a50:ef12:: with SMTP id m18mr19477410eds.313.1604366754607;
        Mon, 02 Nov 2020 17:25:54 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1604366754; cv=none;
        d=google.com; s=arc-20160816;
        b=XAutfCoAh7eQJ4D5itZcLgzBC7CusbYOHiN93zTwrMYMt2Dzo+mEqcXfTZMsWdLX4O
         8DQCF0kNPRpqwzQ6tcobR7v7PomHmr4sP503eM+BZEDUB+tYv9v3GeyD62ZPMP3slpx5
         dOm1RPlJuAtCPGSFe0id+V53nOfDOjcjc4qQNM6+mVdkdBMiMF8X0nPFUidN5VnurjlI
         VCREdHRki3n4yJKnW2FxYljA+JYub/drdJhnig+yLOAGzEeG9juxCLclcDbRO6ph7w2H
         CdnrXdLo1ggfmX58vd1S8EKz6LsPT4WzzuId/bclPySJMaGw3n8GAuWGnQ3vJ+PilTiJ
         Unkw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:content-transfer-encoding:mime-version
         :references:in-reply-to:message-id:subject:cc:to:from:date
         :dkim-signature;
        bh=BgX1vvZs32LNiXgmjx2t0WYBtNukUPZZev3icbnRYnQ=;
        b=FUwu+fEPBj4KPA9BNvJ08L0/XEI4vaK6ywT8hpg4RzZIl47L7UxADyiEuOVmhXnfX5
         9sYLEHLnMGyudwMWN6LwR05mNoXPpjcG92A4a5mMhtiL9esC5ERcRvgnfXRKLLUMQqYR
         DRzjkd46LGobfOwtE4+YJdY+8MevAabBPfudS25/gBA1gjDpsKZ/J7tn3LI/x5Ew9fLb
         EXtstIrQDdq6kXqvP83xnWhyoGcQE2R8mbG+yo7FedaBGo1ODyDU2An+KiA3JidV11xo
         BQeirEmVo445DKdCkqu/HKoJ271yumfjMy/CKNUF5cJWlCeYmE2wgLCyuzfZvx1Lmb1Q
         EdwQ==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=kRc+9DKO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18])
        by mx.google.com with ESMTP id y1si1488909edm.279.2020.11.02.17.25.32;
        Mon, 02 Nov 2020 17:25:54 -0800 (PST)
Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Authentication-Results: mx.google.com;
       dkim=pass header.i=@kernel.org header.s=default header.b=kRc+9DKO;
       spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org;
       dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728368AbgKCBXP (ORCPT <rfc822;rajatbajpailinux@gmail.com>
        + 99 others); Mon, 2 Nov 2020 20:23:15 -0500
Received: from mail.kernel.org ([198.145.29.99]:38580 "EHLO mail.kernel.org"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1728248AbgKCBXN (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Mon, 2 Nov 2020 20:23:13 -0500
Received: from kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net (unknown [163.114.132.1])
        (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
        (No client certificate requested)
        by mail.kernel.org (Postfix) with ESMTPSA id B16632063A;
        Tue,  3 Nov 2020 01:23:11 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=default; t=1604366592;
        bh=ssA16D20e+6tilasRa0zK2RKKAFIEnFFPP/i86RcQ6E=;
        h=Date:From:To:Cc:Subject:In-Reply-To:References:From;
        b=kRc+9DKORiaUyywSyf6Z5ueFh1B59QcTAEJmRNaux56Xa4QywGqS9rGO5WaXIoY9L
         os4K9T46FFEXNSSo65+u9tBQeq6dugosI/YCp5HPmuSt5Y+NV82+YgbWBM54FHhNgU
         snS71WqXQEFDQalfoTZWFecH59Y9TPOMrSuFrB7E=
Date:   Mon, 2 Nov 2020 17:23:10 -0800
From:   Jakub Kicinski <kuba@kernel.org>
To:     Andrew Lunn <andrew@lunn.ch>
Cc:     YueHaibing <yuehaibing@huawei.com>, linux@armlinux.org.uk,
        hkallweit1@gmail.com, davem@davemloft.net, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH] sfp: Fix error handing in sfp_probe()
Message-ID: <20201102172310.40b9dc4a@kicinski-fedora-PC1C0HJN.hsd1.ca.comcast.net>
In-Reply-To: <20201031185605.GA932026@lunn.ch>
References: <20201031031053.25264-1-yuehaibing@huawei.com>
        <20201031185605.GA932026@lunn.ch>
MIME-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 7bit
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sat, 31 Oct 2020 19:56:05 +0100 Andrew Lunn wrote:
> On Sat, Oct 31, 2020 at 11:10:53AM +0800, YueHaibing wrote:
> > gpiod_to_irq() never return 0, but returns negative in
> > case of error, check it and set gpio_irq to 0.
> > 
> > Fixes: 73970055450e ("sfp: add SFP module support")
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>  
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>

Applied, thanks!