Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp164085pxb; Mon, 2 Nov 2020 17:26:00 -0800 (PST) X-Google-Smtp-Source: ABdhPJzh/75Ht3sL//L7dTKdIkOprjRlQaRarc43sOojAcZhKQNaoV3zMO7C1HA7E7m6KCtZ8HHf X-Received: by 2002:a17:906:3689:: with SMTP id a9mr17860669ejc.403.1604366760231; Mon, 02 Nov 2020 17:26:00 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604366760; cv=none; d=google.com; s=arc-20160816; b=bCS5v/J7P2TCL/LkCMi2Eutq6YAsnAyU5fKJJ0kK+BxApe880EIvqXDpJUOr7P97k/ evOs4+3gXqlQjFD/c0O6UhLWC6QNVvZC61yqoGN8mE/rOwilC4wvD0Hr3zBged4CBRvx ZA6DKoy9kSZYLs+NNymQCfx4V320EzMoGy1fs+bls3oYTzrTf3S5ZdmusI+yaen2NhTz AqYjGx6135zUDP4iaXhIHw4Ge0WT3Q88H6SdKAtQI8ML5dLYBmkXgbnogIOascrBdOEd Ad6OT5yijNvRGq43pFuei301MMyDnrxu8si/uwlqgA4lxZs240DzmfbKbtEXAHM+POHU 36Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=dXth8hM2YC2hHedrQDyx7VrUNQCxcy5aXPCPpe0ELXw=; b=mSQyrhbNfbJAVNpNeJun3PnSuyHWpw80Yl3Iz0biveoygLzy1h8mDxEFm2apGOLMX6 vAgfoYwQ+qayl0i7IRa/8qfM5H3zwAyPTWevq69jIBSG+WX0yTASwIs5L0cXgE21yZCw zzSjbsuGyokdBKza3KuYMKf2ynAzSsxw4B0fYEj6VIAyu7qC3SnHkyc8nclAptx+atSk ZIMjl6AJaf+YOhoan6DMLDnyzBxlVUNvpTHtgUB1VnCMQMQ07ehitFQKGydG+7iWDBYU Lv8wigJbJz8xoFiA/swr3Mi+XmsO+5qZB38FnnE2Td3Ji4eviQMeXETri8olIHF0zIM1 boSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2aKAVkwQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id 4si11008842ejy.644.2020.11.02.17.25.37; Mon, 02 Nov 2020 17:26:00 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2aKAVkwQ; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728272AbgKCBU4 (ORCPT + 99 others); Mon, 2 Nov 2020 20:20:56 -0500 Received: from mail.kernel.org ([198.145.29.99]:36030 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728251AbgKCBUw (ORCPT ); Mon, 2 Nov 2020 20:20:52 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E396A2242E; Tue, 3 Nov 2020 01:20:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604366452; bh=Ljkxul3PjWR1Ye/+v0w7PoNPVh2U3HP/n/ZIQZbjAVc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2aKAVkwQr3fai7KvMzs4kuXI8stfzxlW7VyF6WQ1AZxaP0agQDN7/2ns/+OaDLBns YlcuIkTP/zVflnP/c9+BjPsaEGYZV5iJTghXqI1JewCWJyOw3WrYUgXFgCFxBWEHwG x+vMxtBuyq2eoanP39Gp18ciNc2GjzgtOOL0+VoU= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hoegeun Kwon , Maxime Ripard , Sasha Levin , dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 4.19 10/11] drm/vc4: drv: Add error handding for bind Date: Mon, 2 Nov 2020 20:20:38 -0500 Message-Id: <20201103012039.183672-10-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201103012039.183672-1-sashal@kernel.org> References: <20201103012039.183672-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hoegeun Kwon [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ] There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20201027041442.30352-2-hoegeun.kwon@samsung.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 04270a14fcaaf..868dd1ef3b693 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -312,6 +312,7 @@ static int vc4_drm_bind(struct device *dev) component_unbind_all(dev, drm); gem_destroy: vc4_gem_destroy(drm); + drm_mode_config_cleanup(drm); vc4_bo_cache_destroy(drm); dev_put: drm_dev_put(drm); -- 2.27.0