Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp165291pxb; Mon, 2 Nov 2020 17:28:38 -0800 (PST) X-Google-Smtp-Source: ABdhPJyXpcvefLFmn8kEP1rxLaXcmoPuKd67+oOrMYSKd8ElaIvtxXiJr92P8I91UFJEg+KzobQn X-Received: by 2002:a17:906:389a:: with SMTP id q26mr18530053ejd.211.1604366918390; Mon, 02 Nov 2020 17:28:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604366918; cv=none; d=google.com; s=arc-20160816; b=VQCQ7XWSzzoogk0XiLMSWjQTmz6lSmQ403re7LIcFOS2qhjS8cmn7/tXpELNHOqjdC RrIaeLQbUXcBg4YRweg5QmvXDPQsjsOI+SnSU0Y8gqJZZxpOISPCDXQ5W9/0e/++MszY 6X9yksdHvwGxZPBxQ+18paPYRm35GVbk21fAl1n4zl+Au1Mevozut0yfptsmfEgWztR9 JEQ30H9/qPHPF8g5VE8KDnh2pGzp3GH5QhxKPD8/Nck9Yk7HYbnAsEQZKxsVTk+vuH/c 6c5ZGUg2M/os44Dd97mBks65cegvK3Q8/izDmdOJQPtvMEn3yAgFZaAzPfGoShZOg+mw 6lww== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=2m4wyJEfv532k87ozb2XpiZaraLGYdhcqnwO40z0XvA=; b=bkwVorrBijHNzUbVipRr2xqHuudywLEyc9ZAWBoyNJB1U7R2qLWMy0S5rdgWt04uNH yzvRC9iOEJE+9UIqU3KWNXqYk3iCNQrFCREW25f4MIte5gIEqISwbcqu/m0YgLSm1XbO 3HmIznueNHrbnCyYiS623WhAQZBdtXJg+gSHgTV8h7P04ef4x9lkJ/syMR/as8DOaufG 0vosFfqIZbP90OK6ZctHaS1G0TNZ8LjNoI33OR+GVMk9qnXGZPoHIJbjPiQTRTKihP3M qSNFTQIOuzQVvoVWt04LFs/A1EaLg9RX1Hi8//dWazeV5Dekr82fSH0TidcQw6Sx6Nux AVkw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fPKzYLcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r6si9970241edi.184.2020.11.02.17.28.16; Mon, 02 Nov 2020 17:28:38 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=fPKzYLcG; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727730AbgKCBTY (ORCPT + 99 others); Mon, 2 Nov 2020 20:19:24 -0500 Received: from mail.kernel.org ([198.145.29.99]:33068 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727687AbgKCBTV (ORCPT ); Mon, 2 Nov 2020 20:19:21 -0500 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id F0F7B223C7; Tue, 3 Nov 2020 01:19:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604366360; bh=oXlw0sds8OBpAbuRT1r3BD4nyWUh0fJiKDc4ixL3VTo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fPKzYLcGgAlwAdX3OKFECL+HF8AbnU/3HpG4gm2VTdd6vLlI+3ElWc6uClaoYYD37 LRTJ66obn8K14vOjZdWFStluMT0t+BZ3lsYjH6uhqz9dAITqPuLwmXgk45gD4258ul 01+8fz/8gp7DDw3unIxAfLsLwElgkytNCU8Gp+xs= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Hoegeun Kwon , Maxime Ripard , Sasha Levin , dri-devel@lists.freedesktop.org Subject: [PATCH AUTOSEL 5.9 30/35] drm/vc4: drv: Add error handding for bind Date: Mon, 2 Nov 2020 20:18:35 -0500 Message-Id: <20201103011840.182814-30-sashal@kernel.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20201103011840.182814-1-sashal@kernel.org> References: <20201103011840.182814-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Hoegeun Kwon [ Upstream commit 9ce0af3e9573fb84c4c807183d13ea2a68271e4b ] There is a problem that if vc4_drm bind fails, a memory leak occurs on the drm_property_create side. Add error handding for drm_mode_config. Signed-off-by: Hoegeun Kwon Signed-off-by: Maxime Ripard Link: https://patchwork.freedesktop.org/patch/msgid/20201027041442.30352-2-hoegeun.kwon@samsung.com Signed-off-by: Sasha Levin --- drivers/gpu/drm/vc4/vc4_drv.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/gpu/drm/vc4/vc4_drv.c b/drivers/gpu/drm/vc4/vc4_drv.c index 38343d2fb4fb4..f6995e7f6eb6e 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.c +++ b/drivers/gpu/drm/vc4/vc4_drv.c @@ -310,6 +310,7 @@ static int vc4_drm_bind(struct device *dev) component_unbind_all(dev, drm); gem_destroy: vc4_gem_destroy(drm); + drm_mode_config_cleanup(drm); vc4_bo_cache_destroy(drm); dev_put: drm_dev_put(drm); -- 2.27.0