Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Subject: Re: [PATCH v7 2/4] net: phy: Add 5GBASER interface mode
To:     Pavana Sharma <pavana.sharma@digi.com>, andrew@lunn.ch
Cc:     ashkan.boldaji@digi.com, davem@davemloft.net,
        gregkh@linuxfoundation.org, kuba@kernel.org,
        linux-kernel@vger.kernel.org, marek.behun@nic.cz,
        netdev@vger.kernel.org, vivien.didelot@gmail.com
References: <20201102130905.GE1109407@lunn.ch>
 <20201103013446.1220-1-pavana.sharma@digi.com>
From:   Florian Fainelli <f.fainelli@gmail.com>
Message-ID: <7aef297e-cbee-6f04-9d74-82cf97579880@gmail.com>
Date:   Mon, 2 Nov 2020 18:12:32 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101
 Firefox/78.0 Thunderbird/78.4.0
MIME-Version: 1.0
In-Reply-To: <20201103013446.1220-1-pavana.sharma@digi.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk


On 11/2/2020 5:34 PM, Pavana Sharma wrote:
>> How many times have i asked for you to add kerneldoc for this new
>> value? How many times have you not done so?
> 
> I have added kerneldoc comment for the new value added.
> 
>> NACK.
> 
>> If you don't understand a comment, please ask.
> 
> Ok, explain what do you expect by that comment.

What Andrew wants you to do is add a comment like this:

https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy.h#n88
-- 
Florian