Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp202209pxb; Mon, 2 Nov 2020 18:57:41 -0800 (PST) X-Google-Smtp-Source: ABdhPJy/3dJhghD3ULSySxNRIGwpGnwP3DQRTo1bCJeVYNzeL9KkpD23JX+/sbu08My5iF3AdDoH X-Received: by 2002:a17:906:934d:: with SMTP id p13mr17543720ejw.245.1604372261514; Mon, 02 Nov 2020 18:57:41 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604372261; cv=none; d=google.com; s=arc-20160816; b=UR1vXyVIIxrLs7s0NvrY7iPWmvNzzCkESQFxJOyqRJ/6I0GsFGDeK50TnP+3qhQneo kpOs1tuVkfp3TgTpMj5gpvHhvsQ94oyvivvP31jHKQCHAgUyWbupMvMXx7IJT6ktm5LK DKLsq5UcMmQUTGUBWGVrVkux2HHHZR11KBXGgIM2Y5dtHPRTq+SamftDUWzaJWpB1Joc JoAW8dZkHnhx7U8Ba5LfzZFn1/FMfDarToSr2LOKgGdjfsOVLszh1+ihLqMD17C/Ze7+ ljdXj4DhmdH0IXjqyRYgBnXNAFUAEodRET9frWa7oO9jcXKYTaZx892UBcWyIptLWPQH SzQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:content-transfer-encoding:in-reply-to :mime-version:user-agent:date:message-id:from:references:cc:to :subject; bh=lLL4IneNdNYMbHIVjo0ZNH6qFZOgetMhMl81w1BCBY0=; b=PY2cOg6/1iG+qCXUGbGbB5NV3WFHtd7SUAty3jPziz3J9khijTFxEiCRiZqi9i4q8y jXt/x+dlVtG+v6+aaw4lBF7zDFTXRpGIubTC7pNYqzc5ufxqTqG2Az7Er2kzZGVooBth eJCMceXpwVQeJMKLUt7CQrT2yqZSqEclLQYwi9ECI8V6UIegv6WFgGCotWxlORskwa59 fR/88hKIy1cHrfHQDB/DXz+Rj36vjnHohAnbXZ7q/1YoC5l+BpLQFi1uoFpxUkFY8TBi wiUAJZqTNt3dtWRh23GBSVv1nT+srJUIrSjGcXyAplg70wwoOYTxPiu+y+W6jh4PLhpu zo9A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id r22si10930415ejc.124.2020.11.02.18.57.19; Mon, 02 Nov 2020 18:57:41 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=alibaba.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727055AbgKCCyH (ORCPT + 99 others); Mon, 2 Nov 2020 21:54:07 -0500 Received: from out30-42.freemail.mail.aliyun.com ([115.124.30.42]:48735 "EHLO out30-42.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725997AbgKCCyG (ORCPT ); Mon, 2 Nov 2020 21:54:06 -0500 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R191e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=23;SR=0;TI=SMTPD_---0UE2a1yR_1604372041; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0UE2a1yR_1604372041) by smtp.aliyun-inc.com(127.0.0.1); Tue, 03 Nov 2020 10:54:02 +0800 Subject: Re: [PATCH v20 12/20] mm/vmscan: remove lruvec reget in move_pages_to_lru To: Johannes Weiner Cc: akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, willy@infradead.org, lkp@intel.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, cgroups@vger.kernel.org, shakeelb@google.com, iamjoonsoo.kim@lge.com, richard.weiyang@gmail.com, kirill@shutemov.name, alexander.duyck@gmail.com, rong.a.chen@intel.com, mhocko@suse.com, vdavydov.dev@gmail.com, shy828301@gmail.com, Alexander Duyck , Michal Hocko References: <1603968305-8026-1-git-send-email-alex.shi@linux.alibaba.com> <1603968305-8026-13-git-send-email-alex.shi@linux.alibaba.com> <20201102145220.GE724984@cmpxchg.org> From: Alex Shi Message-ID: <3aa7469c-1400-5a21-fece-465db8f4e8ac@linux.alibaba.com> Date: Tue, 3 Nov 2020 10:51:27 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.12.0 MIME-Version: 1.0 In-Reply-To: <20201102145220.GE724984@cmpxchg.org> Content-Type: text/plain; charset=gbk Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ?? 2020/11/2 ????10:52, Johannes Weiner ะด??: > Acked-by: Johannes Weiner > > A brief comment in the code could be good: all pages were isolated > from the same lruvec (and isolation inhibits memcg migration). Yes, I will add the words both in code and commit log. Thanks