Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Date:   Tue, 3 Nov 2020 04:16:43 +0100
From:   Andrew Lunn <andrew@lunn.ch>
To:     Florian Fainelli <f.fainelli@gmail.com>
Cc:     Pavana Sharma <pavana.sharma@digi.com>, ashkan.boldaji@digi.com,
        davem@davemloft.net, gregkh@linuxfoundation.org, kuba@kernel.org,
        linux-kernel@vger.kernel.org, marek.behun@nic.cz,
        netdev@vger.kernel.org, vivien.didelot@gmail.com
Subject: Re: [PATCH v7 2/4] net: phy: Add 5GBASER interface mode
Message-ID: <20201103031643.GJ1109407@lunn.ch>
References: <20201102130905.GE1109407@lunn.ch>
 <20201103013446.1220-1-pavana.sharma@digi.com>
 <7aef297e-cbee-6f04-9d74-82cf97579880@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <7aef297e-cbee-6f04-9d74-82cf97579880@gmail.com>
Precedence: bulk

On Mon, Nov 02, 2020 at 06:12:32PM -0800, Florian Fainelli wrote:
> 
> 
> On 11/2/2020 5:34 PM, Pavana Sharma wrote:
> >> How many times have i asked for you to add kerneldoc for this new
> >> value? How many times have you not done so?
> > 
> > I have added kerneldoc comment for the new value added.
> > 
> >> NACK.
> > 
> >> If you don't understand a comment, please ask.
> > 
> > Ok, explain what do you expect by that comment.
> 
> What Andrew wants you to do is add a comment like this:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/netdev/net-next.git/tree/include/linux/phy.h#n88

Hi Pavana

This should also help:

https://www.kernel.org/doc/html/latest/doc-guide/kernel-doc.html

And please compile the kernel with the W=1 flag. Make sure changes you
make don't add new warnings. You will see a warning from this new enum
valu you are adding because it is not correctly documented.

       Andrew