Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18;
Message-ID: <35625559ea6fa7827e840905a4a03e624fdeb43f.camel@perches.com>
Subject: Re: [PATCH v2] fs/aio.c: Cosmetic
From:   Joe Perches <joe@perches.com>
To:     Andreas Dilger <adilger@dilger.ca>,
        Alejandro Colomar <colomar.6.4.3@gmail.com>
Cc:     Benjamin LaHaise <bcrl@kvack.org>, linux-aio@kvack.org,
        linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Date:   Mon, 02 Nov 2020 19:22:57 -0800
In-Reply-To: <7CCB9FA6-DE85-4E3F-B3F1-7144F01589D4@dilger.ca>
References: <20201102152439.315640-1-colomar.6.4.3@gmail.com>
         <20201102215809.17312-1-colomar.6.4.3@gmail.com>
         <7CCB9FA6-DE85-4E3F-B3F1-7144F01589D4@dilger.ca>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.38.1-1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Precedence: bulk

On Mon, 2020-11-02 at 17:50 -0700, Andreas Dilger wrote:
> On Nov 2, 2020, at 2:58 PM, Alejandro Colomar <colomar.6.4.3@gmail.com> wrote:
> > Changes:
> > - Consistently use 'unsigned int', instead of 'unsigned'.
> > - Add a blank line after variable declarations.
> > - Move variable declarations to the top of functions.
> > - Add a blank line at the top of functions if there are no declarations.
> 
> I'd agree that the other changes are following kernel coding style, but
> I've never heard of leaving a blank line at the start of functions without
> any local variables.

I think that is odd as well.

> I don't see anything in process/coding-style.rst to
> support this change, nor are the majority of variable-less functions
> formatted this way, and it seems to just be a waste of vertical space.

checkpatch emits a --strict CHECK for those blank lines after
open braces


CHECK: Blank lines aren't necessary after an open brace '{'
#200: FILE: fs/aio.c:256:
 {
+

CHECK: Blank lines aren't necessary after an open brace '{'
#246: FILE: fs/aio.c:370:
 {
+

etc...