Received: by 2002:a05:6a10:16a7:0:0:0:0 with SMTP id gp39csp223293pxb; Mon, 2 Nov 2020 19:50:06 -0800 (PST) X-Google-Smtp-Source: ABdhPJxbLbJ76UqD0qpmS6OtelmGfR/gp0k1S0qBJVESoWmqmrk95DQPkIN3qCXNA0hpSDcKAZZF X-Received: by 2002:a05:6402:a57:: with SMTP id bt23mr8704848edb.62.1604375406704; Mon, 02 Nov 2020 19:50:06 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1604375406; cv=none; d=google.com; s=arc-20160816; b=jc6gGvZonbm92hzaHnvcodIvIBGPFeKIm1wf5iCcd5Y1taFPHEGDLe4W7S6pUM5kOL kYE519tHuLaldYUpkwOyGcMro0Yeu/g4eTxb4gvUe6Ov9eb4we/ImOh4sOga6I4oR/pe SUZy8VpAYJ7ZTkgvJprHzToxfCJ7/i83qUw3o/5but4Pc8XD7JZ6P1WVx+4ZoWZiE79t uTu50mR06Ii/RRnVQzhFyTK9rwcfX2gzDFWCcP7AJ5LUSSwAVamQ2wmr5Lj1lv78AibW NHSTJ2BF07zMFmKygPEgZMPs8kN6tBXxiNuJVW32CBOlN9WuAUSW3ps/lgrHRo3b8wpG 457g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:mime-version:message-id:date:subject:to:from; bh=2UEJa8elCp1LiYQuVJlWQyqrqtYQP6dKe420knXFcbw=; b=0IUOHbVEmVFy9vkx3U7gGmVbBpDEdAnWIbT4SHs9XpNyhjUbMgrgEDgc8dRNkUAJHY 7pPflVVy3wX5TsoMGK+9oJhMndJ2RU0Mbd0f5GMnuAqS9GLYSLzyCJMPJfWKTkrd+P2L n5BPFfFGiTlAXaunb8dD4b1lHoc92tt9hNX8zN4IpOjLs1zoZqdEYynIct5CUk5sqt71 xlOAvyvuVev95v0f+4DaxWsiLY8b7JcI6Zzz7SauNbP8+yLpvVvo+1FIbeQ39iWvGAkD AEC/J4T5Ggiuo9QFNqKnepjrYcJNS6KExBaFjM0FWfOXrJNISpAHern/LnQi8VZRZjLi GD3A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id k1si15998826edf.460.2020.11.02.19.49.44; Mon, 02 Nov 2020 19:50:06 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; spf=pass (google.com: domain of linux-kernel-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726042AbgKCDsM (ORCPT + 99 others); Mon, 2 Nov 2020 22:48:12 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:7036 "EHLO szxga05-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725921AbgKCDsM (ORCPT ); Mon, 2 Nov 2020 22:48:12 -0500 Received: from DGGEMS407-HUB.china.huawei.com (unknown [172.30.72.60]) by szxga05-in.huawei.com (SkyGuard) with ESMTP id 4CQG2v6hGCzhfcD; Tue, 3 Nov 2020 11:48:07 +0800 (CST) Received: from localhost.localdomain (10.69.192.56) by DGGEMS407-HUB.china.huawei.com (10.3.19.207) with Microsoft SMTP Server id 14.3.487.0; Tue, 3 Nov 2020 11:48:08 +0800 From: Tian Tao To: , , , , , , , , Subject: [PATCH] mmc: meson-mx-sdio: replace spin_lock_irqsave by spin_lock in hard IRQ Date: Tue, 3 Nov 2020 11:48:43 +0800 Message-ID: <1604375323-33556-1-git-send-email-tiantao6@hisilicon.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 Content-Type: text/plain X-Originating-IP: [10.69.192.56] X-CFilter-Loop: Reflected Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org The code has been in a irq-disabled context since it is hard IRQ. There is no necessity to do it again. Signed-off-by: Tian Tao --- drivers/mmc/host/meson-mx-sdio.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/mmc/host/meson-mx-sdio.c b/drivers/mmc/host/meson-mx-sdio.c index 1c5299c..d4a4891 100644 --- a/drivers/mmc/host/meson-mx-sdio.c +++ b/drivers/mmc/host/meson-mx-sdio.c @@ -418,10 +418,9 @@ static irqreturn_t meson_mx_mmc_irq(int irq, void *data) { struct meson_mx_mmc_host *host = (void *) data; u32 irqs, send; - unsigned long irqflags; irqreturn_t ret; - spin_lock_irqsave(&host->irq_lock, irqflags); + spin_lock(&host->irq_lock); irqs = readl(host->base + MESON_MX_SDIO_IRQS); send = readl(host->base + MESON_MX_SDIO_SEND); @@ -434,7 +433,7 @@ static irqreturn_t meson_mx_mmc_irq(int irq, void *data) /* finally ACK all pending interrupts */ writel(irqs, host->base + MESON_MX_SDIO_IRQS); - spin_unlock_irqrestore(&host->irq_lock, irqflags); + spin_unlock(&host->irq_lock); return ret; } -- 2.7.4